* [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h
@ 2007-12-20 1:19 Bartlomiej Zolnierkiewicz
2007-12-21 12:14 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-12-20 1:19 UTC (permalink / raw)
To: linux-ide; +Cc: linux-kernel
ide-cd.c already uses sense keys definitions from <scsi/scsi.h>.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-cd.h | 17 -----------------
1 file changed, 17 deletions(-)
Index: b/drivers/ide/ide-cd.h
===================================================================
--- a/drivers/ide/ide-cd.h
+++ b/drivers/ide/ide-cd.h
@@ -158,23 +158,6 @@ struct cdrom_info {
*/
/* This stuff should be in cdrom.h, since it is now generic... */
-
-/* ATAPI sense keys (from table 140 of ATAPI 2.6) */
-#define NO_SENSE 0x00
-#define RECOVERED_ERROR 0x01
-#define NOT_READY 0x02
-#define MEDIUM_ERROR 0x03
-#define HARDWARE_ERROR 0x04
-#define ILLEGAL_REQUEST 0x05
-#define UNIT_ATTENTION 0x06
-#define DATA_PROTECT 0x07
-#define BLANK_CHECK 0x08
-#define ABORTED_COMMAND 0x0b
-#define MISCOMPARE 0x0e
-
-
-
-/* This stuff should be in cdrom.h, since it is now generic... */
#if VERBOSE_IDE_CD_ERRORS
/* The generic packet command opcodes for CD/DVD Logical Units,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h
2007-12-20 1:19 [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h Bartlomiej Zolnierkiewicz
@ 2007-12-21 12:14 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-12-21 12:14 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel
Bartlomiej Zolnierkiewicz wrote:
> ide-cd.c already uses sense keys definitions from <scsi/scsi.h>.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-21 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-20 1:19 [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h Bartlomiej Zolnierkiewicz
2007-12-21 12:14 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).