From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] piix: remove stale comments
Date: Fri, 28 Dec 2007 15:02:14 +0300 [thread overview]
Message-ID: <4774E5C6.90506@ru.mvista.com> (raw)
In-Reply-To: <20071227191200.1357.71766.sendpatchset@localhost.localdomain>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/pci/piix.c
> ===================================================================
> --- a/drivers/ide/pci/piix.c
> +++ b/drivers/ide/pci/piix.c
> @@ -8,53 +8,8 @@
> *
> * May be copied or modified under the terms of the GNU General Public License
> *
> - * PIO mode setting function for Intel chipsets.
> - * For use instead of BIOS settings.
> + * Documentation:
> *
> - * 40-41
> - * 42-43
> - *
> - * 41
> - * 43
> - *
> - * | PIO 0 | c0 | 80 | 0 |
> - * | PIO 2 | SW2 | d0 | 90 | 4 |
> - * | PIO 3 | MW1 | e1 | a1 | 9 |
> - * | PIO 4 | MW2 | e3 | a3 | b |
> - *
> - * sitre = word40 & 0x4000; primary
> - * sitre = word42 & 0x4000; secondary
> - *
> - * 44 8421|8421 hdd|hdb
> - *
> - * 48 8421 hdd|hdc|hdb|hda udma enabled
> - *
> - * 0001 hda
> - * 0010 hdb
> - * 0100 hdc
> - * 1000 hdd
> - *
> - * 4a 84|21 hdb|hda
> - * 4b 84|21 hdd|hdc
> - *
> - * ata-33/82371AB
> - * ata-33/82371EB
> - * ata-33/82801AB ata-66/82801AA
> - * 00|00 udma 0 00|00 reserved
> - * 01|01 udma 1 01|01 udma 3
> - * 10|10 udma 2 10|10 udma 4
> - * 11|11 reserved 11|11 reserved
> - *
> - * 54 8421|8421 ata66 drive|ata66 enable
You could have left te progarmming info intact...
WBR, Sergei
next prev parent reply other threads:[~2007-12-28 12:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 19:11 [PATCH 0/9] ide: switch to generic DMA-mapping API Bartlomiej Zolnierkiewicz
2007-12-27 19:12 ` [PATCH 1/9] piix: remove stale comments Bartlomiej Zolnierkiewicz
2007-12-28 12:02 ` Sergei Shtylyov [this message]
2007-12-30 17:09 ` Bartlomiej Zolnierkiewicz
2007-12-27 19:12 ` [PATCH 2/9] ide: fix ide_intr() for non-PCI devices and CONFIG_BLK_DEV_IDEPCI=y Bartlomiej Zolnierkiewicz
2007-12-28 12:15 ` Sergei Shtylyov
2007-12-27 19:12 ` [PATCH 3/9] ide: remove BUG_ON() from ide_build_sglist() Bartlomiej Zolnierkiewicz
2007-12-27 19:12 ` [PATCH 4/9] ide: use ide_destroy_dmatable() instead of pci_unmap_sg() Bartlomiej Zolnierkiewicz
2007-12-29 13:43 ` Sergei Shtylyov
2007-12-27 19:12 ` [PATCH 5/9] ide: keep pointer to struct device instead of struct pci_dev in ide_hwif_t Bartlomiej Zolnierkiewicz
2007-12-27 19:12 ` [PATCH 6/9] au1xxx-ide: use hwif->dev Bartlomiej Zolnierkiewicz
2007-12-27 19:12 ` [PATCH 7/9] icside: " Bartlomiej Zolnierkiewicz
2007-12-28 13:24 ` Sergei Shtylyov
2007-12-29 13:52 ` Sergei Shtylyov
2007-12-29 13:55 ` Sergei Shtylyov
2007-12-27 19:12 ` [PATCH 8/9] ide: switch to DMA-mapping API Bartlomiej Zolnierkiewicz
2008-01-02 8:34 ` Bryan Wu
2007-12-27 19:12 ` [PATCH 9/9] ide: use ide_build_sglist() and ide_destroy_dmatable() in non-PCI host drivers Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4774E5C6.90506@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).