* [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset
@ 2008-01-03 15:22 Tejun Heo
2008-01-03 15:38 ` Mark Lord
2008-01-10 21:54 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Tejun Heo @ 2008-01-03 15:22 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list, Mark Lord
During conversion to new EH, sata_qstor was accidentaly changed to use
softreset, which is buggy on this chip, instead of hardreset. This
patch updates sata_qstor such that it uses hardreset again.
This fixes bugzilla bug 9631.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Mark Lord <mlord@pobox.com>
---
drivers/ata/sata_qstor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/sata_qstor.c b/drivers/ata/sata_qstor.c
index 2f1de6e..c68b241 100644
--- a/drivers/ata/sata_qstor.c
+++ b/drivers/ata/sata_qstor.c
@@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)
static void qs_error_handler(struct ata_port *ap)
{
qs_enter_reg_mode(ap);
- ata_do_eh(ap, qs_prereset, ata_std_softreset, NULL,
+ ata_do_eh(ap, qs_prereset, NULL, sata_std_hardreset,
ata_std_postreset);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset
2008-01-03 15:22 [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset Tejun Heo
@ 2008-01-03 15:38 ` Mark Lord
2008-01-10 21:54 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Mark Lord @ 2008-01-03 15:38 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, IDE/ATA development list
Tejun Heo wrote:
> During conversion to new EH, sata_qstor was accidentaly changed to use
> softreset, which is buggy on this chip, instead of hardreset. This
> patch updates sata_qstor such that it uses hardreset again.
>
> This fixes bugzilla bug 9631.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Mark Lord <mlord@pobox.com>
> ---
> drivers/ata/sata_qstor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_qstor.c b/drivers/ata/sata_qstor.c
> index 2f1de6e..c68b241 100644
> --- a/drivers/ata/sata_qstor.c
> +++ b/drivers/ata/sata_qstor.c
> @@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)
> static void qs_error_handler(struct ata_port *ap)
> {
> qs_enter_reg_mode(ap);
> - ata_do_eh(ap, qs_prereset, ata_std_softreset, NULL,
> + ata_do_eh(ap, qs_prereset, NULL, sata_std_hardreset,
> ata_std_postreset);
> }
>
Ack. This fixes a regression and should go out in 2.6.24.
And now we know that I'm not the only Linux user on the planet
with a QStor card -- there's at least one other out there!
Cheers
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset
2008-01-03 15:22 [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset Tejun Heo
2008-01-03 15:38 ` Mark Lord
@ 2008-01-10 21:54 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-01-10 21:54 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, Mark Lord
Tejun Heo wrote:
> During conversion to new EH, sata_qstor was accidentaly changed to use
> softreset, which is buggy on this chip, instead of hardreset. This
> patch updates sata_qstor such that it uses hardreset again.
>
> This fixes bugzilla bug 9631.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Mark Lord <mlord@pobox.com>
> ---
> drivers/ata/sata_qstor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-10 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-03 15:22 [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset Tejun Heo
2008-01-03 15:38 ` Mark Lord
2008-01-10 21:54 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).