From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset Date: Thu, 03 Jan 2008 10:38:02 -0500 Message-ID: <477D015A.3050807@rtr.ca> References: <477CFDAB.3090705@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:1729 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbYACPiE (ORCPT ); Thu, 3 Jan 2008 10:38:04 -0500 In-Reply-To: <477CFDAB.3090705@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , IDE/ATA development list Tejun Heo wrote: > During conversion to new EH, sata_qstor was accidentaly changed to use > softreset, which is buggy on this chip, instead of hardreset. This > patch updates sata_qstor such that it uses hardreset again. > > This fixes bugzilla bug 9631. > > Signed-off-by: Tejun Heo > Cc: Mark Lord > --- > drivers/ata/sata_qstor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/sata_qstor.c b/drivers/ata/sata_qstor.c > index 2f1de6e..c68b241 100644 > --- a/drivers/ata/sata_qstor.c > +++ b/drivers/ata/sata_qstor.c > @@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val) > static void qs_error_handler(struct ata_port *ap) > { > qs_enter_reg_mode(ap); > - ata_do_eh(ap, qs_prereset, ata_std_softreset, NULL, > + ata_do_eh(ap, qs_prereset, NULL, sata_std_hardreset, > ata_std_postreset); > } > Ack. This fixes a regression and should go out in 2.6.24. And now we know that I'm not the only Linux user on the planet with a QStor card -- there's at least one other out there! Cheers