From: Kevin Winchester <kjwinchester@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
paolo.ciarrocchi@gmail.com, gorcunov@gmail.com,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Date: Tue, 08 Jan 2008 19:50:47 -0400 [thread overview]
Message-ID: <47840C57.6000304@gmail.com> (raw)
In-Reply-To: <20080108164015.GC31504@one.firstfloor.org>
Andi Kleen wrote:
> Here's a proposal for some useful code transformations the kernel janitors
> could do as opposed to running checkpatch.pl.
>
<snip>
I notice that every driver in drivers/ata uses a .ioctl that points to
ata_scsi_ioctl(). I could add the BKL to that function, and then change
all of the drivers to .unlocked_ioctl, but I assume this would be a
candidate to actually clean up by determining why the lock is needed and
removing it if necessary. Does anyone know off-hand the reason for
needing the lock (I assume someone does or it wouldn't have survived
this long)? If the lock is absolutely required, then I can write the
patch to add lock_kernel() and unlock_kernel().
--
Kevin Winchester
next parent reply other threads:[~2008-01-08 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080108164015.GC31504@one.firstfloor.org>
2008-01-08 23:50 ` Kevin Winchester [this message]
2008-01-09 0:09 ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Andi Kleen
2008-01-09 0:17 ` Kevin Winchester
2008-01-09 0:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47840C57.6000304@gmail.com \
--to=kjwinchester@gmail.com \
--cc=andi@firstfloor.org \
--cc=gorcunov@gmail.com \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).