linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Andrew Ryder <tireman@shaw.ca>,
	"Gaston, Jason D" <jason.d.gaston@intel.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: Sata 4726 Testing
Date: Wed, 09 Jan 2008 14:45:53 +0900	[thread overview]
Message-ID: <47845F91.9000705@gmail.com> (raw)
In-Reply-To: <47832D82.2020106@shaw.ca>

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Please apply the attached patch on top of 2.6.24-rc7 and report the
result.  Thanks.

-- 
tejun

[-- Attachment #2: simg-pmp-quirk.patch --]
[-- Type: text/x-patch, Size: 1173 bytes --]

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index c0c4dbc..c07566c 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -467,7 +467,8 @@ static void sata_pmp_quirks(struct ata_port *ap)
 
 			/* class code report is unreliable */
 			if (link->pmp < 5)
-				link->flags |= ATA_LFLAG_ASSUME_ATA;
+				link->flags |= ATA_LFLAG_NO_SRST |
+					       ATA_LFLAG_ASSUME_ATA;
 
 			/* port 5 is for SEMB device and it doesn't like SRST */
 			if (link->pmp == 5)
@@ -482,7 +483,8 @@ static void sata_pmp_quirks(struct ata_port *ap)
 
 			/* class code report is unreliable */
 			if (link->pmp < 2)
-				link->flags |= ATA_LFLAG_ASSUME_ATA;
+				link->flags |= ATA_LFLAG_NO_SRST |
+					       ATA_LFLAG_ASSUME_ATA;
 
 			/* the config device at port 2 locks up on SRST */
 			if (link->pmp == 2)
@@ -497,7 +499,8 @@ static void sata_pmp_quirks(struct ata_port *ap)
 
 			/* class code report is unreliable */
 			if (link->pmp < 5)
-				link->flags |= ATA_LFLAG_ASSUME_ATA;
+				link->flags |= ATA_LFLAG_NO_SRST |
+					       ATA_LFLAG_ASSUME_ATA;
 
 			/* The config device, which can be either at
 			 * port 0 or 5, locks up on SRST.

  reply	other threads:[~2008-01-09  5:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4769A17A.8070806@shaw.ca>
     [not found] ` <4769F974.2020905@gmail.com>
2007-12-20 22:23   ` Sata 4726 Testing Andrew Ryder
2007-12-22 13:53   ` Andrew Ryder
2008-01-07 16:12     ` Tejun Heo
2008-01-07 22:28       ` Andrew Ryder
2008-01-08  3:54         ` Tejun Heo
2008-01-08  8:00           ` Andrew Ryder
2008-01-09  5:45             ` Tejun Heo [this message]
2008-01-09 17:47               ` Andrew Ryder
2008-01-10  0:53                 ` Tejun Heo
2008-01-10  1:58                   ` Gaston, Jason D
2008-01-10  3:19                     ` Tejun Heo
2008-01-10 16:24                       ` Gaston, Jason D
2008-01-10  3:29               ` Tejun Heo
2008-01-09 23:00                 ` Andrew Ryder
2008-01-10  4:20                   ` Tejun Heo
2008-01-09 23:55                     ` Andrew Ryder
2008-01-10  6:36                       ` Tejun Heo
2008-01-11  1:19                         ` Andrew Ryder
2008-01-11  7:49                           ` Tejun Heo
2008-01-11 23:13                             ` Andrew Ryder
2008-01-13  5:10                               ` Tejun Heo
2008-01-13 19:01                                 ` Andrew Ryder
2008-01-14  0:35                                   ` Tejun Heo
2008-01-19 22:05                                     ` Andrew Ryder
2008-01-20  3:21                                       ` Tejun Heo
2008-01-14 19:07                                 ` Gaston, Jason D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47845F91.9000705@gmail.com \
    --to=htejun@gmail.com \
    --cc=jason.d.gaston@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tireman@shaw.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).