From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4
Date: Fri, 11 Jan 2008 10:00:48 +0900 [thread overview]
Message-ID: <4786BFC0.3010704@gmail.com> (raw)
In-Reply-To: <47869313.7060306@garzik.org>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> VMware ich4 emulation incorrectly sets DMA_ERR on TF error. Ignore
>> it.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> hrm. IIRC, the old-IDE code just sorta ignores this, and in the
> original libata I followed old-IDE's habit of acking events with
>
> write-to-dma-status-register(err | intr)
>
> so what part of libata-core cares about this distinction? what is the
> specific behavior from the original problem report that this solves?
Well, basically, some versions of vmware sets DMA_ERR on CHECK_SENSE, so
cdroms get reset when they try to report sense data.
Thanks.
--
tejun
prev parent reply other threads:[~2008-01-11 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 10:38 [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4 Tejun Heo
2008-01-10 21:50 ` Jeff Garzik
2008-01-11 1:00 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4786BFC0.3010704@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).