From: Jim Ramsay <jim.ramsay@gmail.com>
To: Lukasz Kosewski <lkosewsk@gmail.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Jeff Garzik <jgarzik@pobox.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
Date: Tue, 6 Sep 2005 13:02:07 -0600 [thread overview]
Message-ID: <4789af9e05090612023fb8517c@mail.gmail.com> (raw)
In-Reply-To: <4789af9e0508291223435f174@mail.gmail.com>
Regarding the sata_promise.c patch, I think I have found a bug in the
interrupt handler:
Just before the 'try_hotplug' label, you provide a check that will
kick us out of the interrupt handler if the interrupt was just handled
by a DMA command completing successfully.
However, I have seen the occasion where a single IRQ is used to signal
both a DMA completion AND a hotplug event. Of course in this case the
hotplug event itself would be ignored completely.
So I would recommend getting rid of that check entirely.
--
Jim Ramsay
"Me fail English? That's unpossible!"
next prev parent reply other threads:[~2005-09-06 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 10:02 [PATCH 3/3] Add disk hotswap support to libata RESEND #2 Lukasz Kosewski
2005-08-23 19:41 ` Jim Ramsay
2005-08-23 22:43 ` Jim Ramsay
2005-08-23 22:56 ` George Anzinger
2005-08-24 1:20 ` Stefan Richter
2005-08-24 14:03 ` Lukasz Kosewski
2005-08-24 15:11 ` Jim Ramsay
2005-08-24 16:12 ` Jim Ramsay
[not found] ` <4789af9e0508291223435f174@mail.gmail.com>
2005-08-29 19:45 ` Jim Ramsay
2005-09-06 19:02 ` Jim Ramsay [this message]
2005-09-15 4:40 ` Lukasz Kosewski
2005-09-16 16:11 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4789af9e05090612023fb8517c@mail.gmail.com \
--to=jim.ramsay@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkosewsk@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).