[PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Peter Schwenke]

From: Peter Schwenke <peter@bluetoad.com.au>

Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.  This is
from OSDL bug 7780.

Signed-off-by: Peter Schwenke <peter@bluetoad.com.au>
---
 drivers/ata/ata_piix.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index bb62a58..867a263 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -988,6 +988,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "TECRA M6",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "TECRA M6"),
+			},
+		},
+		{
 			.ident = "TECRA M7",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
@@ -1002,6 +1009,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "Satellite R20",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "Satellite R20"),
+			},
+		},
+		{
 			.ident = "Satellite R25",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
-- 
1.5.2.5

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Tejun Heo]

Peter Schwenke wrote:
> From: Peter Schwenke <peter@bluetoad.com.au>
> 
> Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.  This is
> from OSDL bug 7780.
> 
> Signed-off-by: Peter Schwenke <peter@bluetoad.com.au>

Acked-by: Tejun Heo <htejun@gmail.com>

If Toshiba is still doing this for their new products.  We either need a
better way to blacklist them or contact and tell them to stop what
they're doing.  Does anyone have a Toshiba contact?

Thanks.

-- 
tejun

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Peter Schwenke]

Tejun Heo wrote:
> If Toshiba is still doing this for their new products.  We either need a
> better way to blacklist them or contact and tell them to stop what
> they're doing.  Does anyone have a Toshiba contact?
> 

I've been thinking the same thing.  It appears that all their newer
laptops are doing this - and they have a lot of models.

So we probably do need a better method of blacklisting them and also let
Toshiba know.

I have found a contact for engineering at linux@toshiba-dme.co.jp
from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.

I'm willing to send them some mail if nobody else wants to or they have
an "inside" contact.

I also realised I didn't give attribution to Matt Piermarini  for the M6
  lines in my comment.

-- 
                                                              ...Peter

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Tejun Heo]

Peter Schwenke wrote:
> Tejun Heo wrote:
>> If Toshiba is still doing this for their new products.  We either need a
>> better way to blacklist them or contact and tell them to stop what
>> they're doing.  Does anyone have a Toshiba contact?
>>
> 
> I've been thinking the same thing.  It appears that all their newer
> laptops are doing this - and they have a lot of models.
> 
> So we probably do need a better method of blacklisting them and also let
> Toshiba know.
> 
> I have found a contact for engineering at linux@toshiba-dme.co.jp
> from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.
> 
> I'm willing to send them some mail if nobody else wants to or they have
> an "inside" contact.

Yes, please go ahead and cc me and Jeff.

> I also realised I didn't give attribution to Matt Piermarini  for the M6
>   lines in my comment.

Feel free to post updated version.

Thanks.

-- 
tejun

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Peter Schwenke]

> Peter Schwenke wrote:
>> Tejun Heo wrote:
>>
>> I have found a contact for engineering at linux@toshiba-dme.co.jp
>> from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.
>>
>> I'm willing to send them some mail if nobody else wants to or they have
>> an "inside" contact.
> 
> Yes, please go ahead and cc me and Jeff.

Will do.

> 
>> I also realised I didn't give attribution to Matt Piermarini  for the M6
>>   lines in my comment.
> 
> Feel free to post updated version.
> 

Thank you. Coming in the next message in this thread.

-- 
                                                              Regards
                                                              ...Peter

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Peter Schwenke]

From: Peter Schwenke <peter@bluetoad.com.au>

Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.  Matt
Piermarini reported and provided the M6 patch.  This is from OSDL bug 7780.

Signed-off-by: Peter Schwenke <peter@bluetoad.com.au>
Cc: Matt Piermarini <mattpiermarini@yahoo.com>
---
 drivers/ata/ata_piix.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index bb62a58..867a263 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -988,6 +988,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "TECRA M6",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "TECRA M6"),
+			},
+		},
+		{
 			.ident = "TECRA M7",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
@@ -1002,6 +1009,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "Satellite R20",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "Satellite R20"),
+			},
+		},
+		{
 			.ident = "Satellite R25",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
-- 
1.5.2.5

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

[Tejun Heo]

Peter Schwenke wrote:
> From: Peter Schwenke <peter@bluetoad.com.au>
> 
> Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.  Matt
> Piermarini reported and provided the M6 patch.  This is from OSDL bug 7780.
> 
> Signed-off-by: Peter Schwenke <peter@bluetoad.com.au>
> Cc: Matt Piermarini <mattpiermarini@yahoo.com>

Acked-by: Tejun Heo <htejun@gmail.com>

-- 
tejun