From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: WARNING: at drivers/ata/libata-core.c:5988 ata_qc_issue()
Date: Fri, 25 Jan 2008 08:57:51 +0900 [thread overview]
Message-ID: <479925FF.4060501@gmail.com> (raw)
In-Reply-To: <479924B5.5060202@rtr.ca>
Mark Lord wrote:
> Tejun Heo wrote:
>> Mark Lord wrote:
>>> Tejun Heo wrote:
>>>> Mark Lord wrote:
>>>>> Tejun,
> ..
>>>> void ata_qc_issue(struct ata_queued_cmd *qc)
>>>> {
>>>> struct ata_port *ap = qc->ap;
>>>> struct ata_link *link = qc->dev->link;
>>>>
>>>> /* Make sure only one non-NCQ command is outstanding. The
>>>> * check is skipped for old EH because it reuses active qc to
>>>> * request ATAPI sense.
>>>> */
>>> = WARN_ON(ap->ops->error_handler &&
>>
>> Hmm... Thanks. Do you have your ->qc_defer set?
> ..
>
> Err.. no, never heard of it before (now).
>
> I suppose I should have it set to the default ?
Yeah, just set it to ata_std_qc_defer().
> sata_mv patch 15/14 forthcoming
:-)
--
tejun
next prev parent reply other threads:[~2008-01-24 23:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 15:20 WARNING: at drivers/ata/libata-core.c:5988 ata_qc_issue() Mark Lord
2008-01-24 15:26 ` Tejun Heo
2008-01-24 15:56 ` Mark Lord
2008-01-24 23:36 ` Tejun Heo
2008-01-24 23:52 ` Mark Lord
2008-01-24 23:57 ` Tejun Heo [this message]
2008-01-25 0:02 ` Mark Lord
2008-01-25 0:07 ` Tejun Heo
2008-01-25 4:01 ` Mark Lord
2008-01-25 4:08 ` Tejun Heo
2008-01-25 4:29 ` Mark Lord
2008-01-25 4:36 ` Tejun Heo
2008-01-25 7:20 ` Jeff Garzik
2008-01-25 7:18 ` Jeff Garzik
2008-01-25 15:01 ` James Bottomley
2008-01-25 15:18 ` Mark Lord
2008-01-25 15:29 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479925FF.4060501@gmail.com \
--to=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).