From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables Date: Wed, 30 Jan 2008 12:19:08 -0500 Message-ID: <47A0B18C.1060300@rtr.ca> References: <479BC217.60709@rtr.ca> <479BC31D.1050206@rtr.ca> <479F5E1F.8030508@pobox.com> <479F6F40.7040401@rtr.ca> <47A04954.7010306@pobox.com> <47A0A875.1070203@rtr.ca> <47A0AF1F.1070609@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:2139 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758908AbYA3RTJ (ORCPT ); Wed, 30 Jan 2008 12:19:09 -0500 In-Reply-To: <47A0AF1F.1070609@pobox.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik , Tejun Heo Cc: IDE/ATA development list Jeff Garzik wrote: > Mark Lord wrote: >> Meanwhile, no further action required here. > > ACK :) > > And thanks for rounding out the NCQ work. sata_mv has needed love and > attention for a while (well, really, its entire life). .. Well, it's going to be getting plenty of TLC over the next few months. In the short term, my plan is to submit further small patches to fix the IRQ and error-handling in sata_mv, as bug fixes for 2.6.25. Note that hot plug/unplug will begin to work correctly once the IRQ/EH code gets fixed (it sort of works already, but sometimes kills the machine). There are also some errata that need to be addressed in the 2.6.25 timeframe. In particular, there's an NCQ EH errata for the 60x1 chips, and a tricky issue about HOB access not working correctly on most versions of the chips. Bigger stuff that I'm deferring for 2.6.26: -- Port multiplier support (though this does look rather simple..) -- power management support -- ATAPI -- IRQ Coalescing -- Target Mode support (interfaces yet to be defined) -- TCQ support: would be good in general for libata on smart hosts, but I'm not sure of the impact on libata EH processing. How's that all sound to you guys? Cheers