From: Jeff Garzik <jeff@garzik.org>
To: saeed.bishara@gmail.com
Cc: linux-ide@vger.kernel.org, saeed@marvell.com, htejun@gmail.com,
liml@rtr.ca, Saeed Bishara <saeed@il.marvell.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers
Date: Fri, 01 Feb 2008 11:53:30 -0500 [thread overview]
Message-ID: <47A34E8A.6020007@garzik.org> (raw)
In-Reply-To: <12017334492566-git-send-email-saeed.bishara@gmail.com>
saeed.bishara@gmail.com wrote:
> --- /dev/null
> +++ b/include/linux/sata_mv.h
> @@ -0,0 +1,21 @@
> +/*
> + * Marvell integrated SATA platfrom device data definition file.
> + *
> + * Saeed Bishara <saeed@marvell.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#ifndef __LINUX_SATA_MV_H__
> +#define __LINUX_SATA_MV_H__
> +
> +/*
> + * Sata private data
> + */
> +struct mv_sata_platform_data {
> + int n_ports; /* number of sata ports */
> +};
> +
> +#endif
Overall, the patch is OK, but I fear adding way too many of these tiny
includes, for each platform.
Unless Paul M objects (pata_platform maintainer), I will rename
linux/pata_platform.h to linux/ata_platform.h, and we can put your
mv_sata_platform_data structure in there.
Jeff
next prev parent reply other threads:[~2008-02-01 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 22:50 [PATCH 1/2 v3] sata_mv: Remove PCI dependency saeed.bishara
2008-01-30 22:50 ` [PATCH 2/2 v3] sata_mv: Support SoC controllers saeed.bishara
2008-02-01 16:53 ` Jeff Garzik [this message]
2008-02-01 18:15 ` Paul Mundt
2008-02-01 19:54 ` saeed bishara
2008-02-01 23:08 ` Jeff Garzik
2008-02-01 16:50 ` [PATCH 1/2 v3] sata_mv: Remove PCI dependency Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A34E8A.6020007@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=lethal@linux-sh.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=saeed.bishara@gmail.com \
--cc=saeed@il.marvell.com \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).