From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH #upstream] libata: make EH fail gracefully if no reset method is available Date: Fri, 01 Feb 2008 15:35:12 -0500 Message-ID: <47A38280.6000806@garzik.org> References: <47A040E2.1050801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:46427 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756971AbYBAUfP (ORCPT ); Fri, 1 Feb 2008 15:35:15 -0500 In-Reply-To: <47A040E2.1050801@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: IDE/ATA development list Tejun Heo wrote: > When no reset method is available, libata currently oopses. Although > the condition can't happen unless there's a bug in a low level driver, > oopsing isn't the best way to report the error condition. Complain, > dump stack and fail reset instead. > > Signed-off-by: Tejun Heo > --- > This patch is on top of > > upstream (a984f58dd97f22f5113700322fed311a0ee29947) > + prefer-hardreset patchset > http://thread.gmane.org/gmane.linux.ide/27447 > > drivers/ata/libata-eh.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) ACK (held in mbox, due to waiting on drive manufacturers' responses)