From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bbpetkov@yahoo.de>
Subject: Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()
Date: Sun, 03 Feb 2008 20:16:42 +0300 [thread overview]
Message-ID: <47A5F6FA.3000107@ru.mvista.com> (raw)
In-Reply-To: <200802021922.56703.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-tape.c
> ===================================================================
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
>
> /* Check that we can support this device */
>
> - if (gcw.protocol !=2 )
> - printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
> + if (gcw.protocol != 2)
> + printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
> + gcw.protocol);
> else if (gcw.device_type != 1)
> - printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
> + printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
> + "to tape\n", gcw.device_type);
> else if (!gcw.removable)
> printk(KERN_ERR "ide-tape: The removable flag is not set\n");
> else if (gcw.packet_size != 0) {
> - printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
> - if (gcw.packet_size == 1)
> - printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
> + printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
> + "bytes long\n", gcw.packet_size);
Shouldn't it be either "packet size is not 12 byted" or "packet is not 12
bytes long"?
MBR, Sergei
next prev parent reply other threads:[~2008-02-03 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 18:22 [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device() Bartlomiej Zolnierkiewicz
2008-02-03 17:16 ` Sergei Shtylyov [this message]
2008-02-04 11:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A5F6FA.3000107@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bbpetkov@yahoo.de \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).