From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()
Date: Wed, 06 Feb 2008 21:08:13 +0300 [thread overview]
Message-ID: <47A9F78D.20904@ru.mvista.com> (raw)
In-Reply-To: <200802020146.30385.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Same BUG_ON() is present inside ide_set_handler().
There is no BUG_ON there -- __ide_set_handler() has a check for the same
condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()...
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2008-02-06 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 0:46 [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc() Bartlomiej Zolnierkiewicz
2008-02-06 18:08 ` Sergei Shtylyov [this message]
2008-02-06 20:43 ` Bartlomiej Zolnierkiewicz
2008-02-07 12:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A9F78D.20904@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).