From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] pata_ninja32: setup changes
Date: Fri, 08 Feb 2008 18:36:14 +0300 [thread overview]
Message-ID: <47AC76EE.9010804@ru.mvista.com> (raw)
In-Reply-To: <20080208152510.06d9af0a@core>
Alan Cox wrote:
> Forcibly set more of the configuration at init time. This seems to fix at
> least one problem reported. We don't know what most of these bits do, but
> we do know what windows stuffs there.
> Signed-off-by: Alan Cox <alan@redhat.com>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/ata/pata_ninja32.c linux-2.6.24-mm1/drivers/ata/pata_ninja32.c
> --- linux.vanilla-2.6.24-mm1/drivers/ata/pata_ninja32.c 2008-02-06 14:14:39.000000000 +0000
> +++ linux-2.6.24-mm1/drivers/ata/pata_ninja32.c 2008-02-06 14:31:57.000000000 +0000
> @@ -17,6 +17,7 @@
> * Base + 0x00 IRQ Status
> * Base + 0x01 IRQ control
> * Base + 0x02 Chipset control
> + * Base + 0x03 Unknown
> * Base + 0x04 VDMA and reset control + wait bits
Why not:
+ * Base + 0x05 Unknown
> * Base + 0x08 BMIMBA
> * Base + 0x0C DMA Length
> @@ -174,8 +175,12 @@
> ata_std_ports(&ap->ioaddr);
>
> iowrite8(0x05, base + 0x01); /* Enable interrupt lines */
> - iowrite8(0xB3, base + 0x02); /* Burst, ?? setup */
> - iowrite8(0x00, base + 0x04); /* WAIT0 ? */
> + iowrite8(0xBE, base + 0x02); /* Burst, ?? setup */
> + iowrite8(0x01, base + 0x03); /* Unknown */
> + iowrite8(0x20, base + 0x04); /* WAIT0 */
> + iowrite8(0x8f, base + 0x05); /* Unknown */
> + iowrite8(0xa4, base + 0x1c); /* Unknown */
> + iowrite8(0x83, base + 0x1d); /* BMDMA control: WAIT0 */
> /* FIXME: Should we disable them at remove ? */
> return ata_host_activate(host, dev->irq, ata_interrupt,
> IRQF_SHARED, &ninja32_sht);
MBR, Sergei
next prev parent reply other threads:[~2008-02-08 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 15:25 [PATCH] pata_ninja32: setup changes Alan Cox
2008-02-08 15:36 ` Sergei Shtylyov [this message]
2008-02-11 19:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AC76EE.9010804@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).