From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/3] palm_bk3710: factor out cable detection Date: Fri, 08 Feb 2008 20:34:40 +0300 Message-ID: <47AC92B0.4080408@ru.mvista.com> References: <200802071542.29628.bzolnier@gmail.com> <47AB1882.8060103@ru.mvista.com> <58cb370e0802070814y44e37cf4h91f57fd4bc993133@mail.gmail.com> <200802072151.49510.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from homer.mvista.com ([63.81.120.155]:60976 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757178AbYBHRds (ORCPT ); Fri, 8 Feb 2008 12:33:48 -0500 In-Reply-To: <200802072151.49510.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Salnikov Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] palm_bk3710: use struct ide_port_info > * Factor out cable detection to palm_bk3710_cable_detect(). > * Add palm_bk3710_init_hwif() (->init_hwif method implementation). > * Remove needless ->quirkproc initialization. > * Add missing ->pio_mask initialization. > * Use ATA_* defines for setting ->{ultra,mwdma}_mask. > * Add 'struct ide_port_info palm_bk3710_port_info' and pass it to > ide_device_add(). Then remove open-coded 'hwif' initialization. > Cc: Anton Salnikov > Cc: Sergei Shtylyov > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sergei Shtylyov MBR, Sergei