From: Tejun Heo <htejun@gmail.com>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, liml@rtr.ca,
alan@lxorguk.ukuu.org.uk, kngregertsen@norway.atmel.com,
sonic.adi@gmail.com, rmk@arm.linux.org.uk,
alessandro.zummo@towertech.it, domen.puncer@telargo.com,
leoli@freescale.com
Subject: Re: [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations, take #2
Date: Wed, 13 Feb 2008 09:03:16 +0900 [thread overview]
Message-ID: <47B233C4.2080700@gmail.com> (raw)
In-Reply-To: <200802122354.m1CNsV4n011311@toshiba.co.jp>
Akira Iguchi wrote:
> Tejun Heo wrote:
>> * pata_scc should now have NULL thaw after conversion.
>
> I'm sorry. This is a bug.
> Please use default thaw (ata_bmdma_thaw) for pata_scc.
That change should be a separate patch. This patchset shouldn't change
any actual behavior but adding ata_bmdma_thaw does change the behavior.
Can you please submit a separate patch to fix it?
Thanks.
--
tejun
prev parent reply other threads:[~2008-02-13 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 8:43 [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations, take #2 Tejun Heo
2008-02-12 8:43 ` [PATCH 01/10] libata: PCI device should be powered up before being accessed Tejun Heo
2008-02-12 8:43 ` [PATCH 02/10] libata: reorganize ata_port_operations Tejun Heo
2008-02-12 8:43 ` [PATCH 03/10] libata: implement and use ata_noop_irq_clear() Tejun Heo
2008-02-12 8:43 ` [PATCH 04/10] libata: normalize port_info, port_operations and sht tables Tejun Heo
2008-02-12 8:43 ` [PATCH 05/10] libata: implement and use SHT initializers Tejun Heo
2008-02-12 8:43 ` [PATCH 06/10] libata: implement and use ops inheritance Tejun Heo
2008-02-12 8:43 ` [PATCH 07/10] libata: make ata_pci_init_one() not use ops->irq_handler and pi->sht Tejun Heo
2008-02-12 8:43 ` [PATCH 08/10] libata: stop overloading port_info->private_data Tejun Heo
2008-02-12 8:43 ` [PATCH 09/10] libata: kill port_info->sht and ->irq_handler Tejun Heo
2008-02-12 8:43 ` [PATCH 10/10] libata: make reset related methods proper port operations Tejun Heo
2008-02-12 13:25 ` How to verify sht-ops-conversion patch doesn't change anything Tejun Heo
2008-02-12 23:55 ` [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations, take #2 Akira Iguchi
2008-02-13 0:03 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B233C4.2080700@gmail.com \
--to=htejun@gmail.com \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alessandro.zummo@towertech.it \
--cc=domen.puncer@telargo.com \
--cc=jeff@garzik.org \
--cc=kngregertsen@norway.atmel.com \
--cc=leoli@freescale.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=sonic.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).