From: Jeff Garzik <jeff@garzik.org>
To: "Cai, Crane" <Crane.Cai@amd.com>
Cc: linux-ide@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] PCI subsystem: AMD SATA IDE mode quirk
Date: Wed, 13 Feb 2008 07:02:32 -0500 [thread overview]
Message-ID: <47B2DC58.3000001@garzik.org> (raw)
In-Reply-To: <206C6845C72CAE439DC3D9D413C571A487B751@ssuzexmb3.amd.com>
Cai, Crane wrote:
> Hi Jeff,
> Sorry to diturb you. However, it is a long time for me to submit this patch. Can you tell me when this patch can be upsteamed to the kernel tree?
> Thanks,
> Crane
>
> -----Original Message-----
> From: Jeff Garzik [mailto:jeff@garzik.org]
> Sent: Saturday, February 02, 2008 2:20 PM
> To: Cai, Crane
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; linux-pci@atrey.karlin.mff.cuni.cz; Linux IDE mailing list
> Subject: Re: [PATCH] PCI subsystem: AMD SATA IDE mode quirk
>
> Cai, Crane wrote:
>> From: Crane Cai <crane.cai@amd.com>
>>
>> PCI: modify SATA IDE mode quirk
>> When initialize and resume, SB600/700/800 need to set SATA mode
>> correctly.
>>
>> Signed-off-by: Crane Cai <crane.cai@amd.com>
>> --------------------------------------------
>> --- a/drivers/pci/quirks.c 2007-09-24 14:16:32.000000000 -0400
>> +++ b/drivers/pci/quirks.c 2008-02-02 11:23:47.000000000 -0500
>> @@ -859,12 +859,13 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>> DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL,
>> PCI_DEVICE_ID_INTEL_82454NX, quirk_disable_pxb );
>>
>>
>> -static void __devinit quirk_sb600_sata(struct pci_dev *pdev)
>> +static void __devinit quirk_amd_ide_mode(struct pci_dev *pdev)
>> {
>> - /* set sb600 sata to ahci mode */
>> - if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
>> - u8 tmp;
>> + /* set sb600/sb700/sb800 sata to ahci mode */
>> + u8 tmp;
>>
>> + pci_read_config_byte(pdev, PCI_CLASS_DEVICE, &tmp);
>> + if (tmp == 0x01) {
>> pci_read_config_byte(pdev, 0x40, &tmp);
>> pci_write_config_byte(pdev, 0x40, tmp|1);
>> pci_write_config_byte(pdev, 0x9, 1); @@ -872,10 +873,13 @@ static
>> void __devinit quirk_sb600_sata(s
>> pci_write_config_byte(pdev, 0x40, tmp);
>>
>> pdev->class = PCI_CLASS_STORAGE_SATA_AHCI;
>> + printk(KERN_INFO "PCI: set SATA to AHCI mode\n");
>> }
>> }
>> -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_sb600_sata);
>> -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_sb600_sata);
>> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_amd_ide_mode);
>> +DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_amd_ide_mode);
>> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_amd_ide_mode);
>> +DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_ATI,
>> PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_amd_ide_mode);
>
> ACK
>
> In the future, please also CC linux-ide@vger.kernel.org, as that's where the ATA folks hang out :)
Greg Kroah-Hartman (cc'd) needs to pick up your patch, since it is in
the "PCI" side of the house...
Jeff
next prev parent reply other threads:[~2008-02-13 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <206C6845C72CAE439DC3D9D413C571A487B327@ssuzexmb3.amd.com>
2008-02-02 6:19 ` [PATCH] PCI subsystem: AMD SATA IDE mode quirk Jeff Garzik
2008-02-13 8:31 ` Cai, Crane
2008-02-13 12:02 ` Jeff Garzik [this message]
2008-02-14 21:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2DC58.3000001@garzik.org \
--to=jeff@garzik.org \
--cc=Crane.Cai@amd.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).