linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Mark Mason <mason@postdiluvian.org>,
	linux-ide@vger.kernel.org, jgarzik@pobox.com,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH] libata: align ap->sector_buf to cacheline
Date: Thu, 14 Feb 2008 18:44:03 +0900	[thread overview]
Message-ID: <47B40D63.6060507@gmail.com> (raw)
In-Reply-To: <47B3AFDC.5040605@gmail.com>

ap->sector_buf is used as DMA target and misalignment can cause data
corruption on non-coherent architectures.  This problem is spotted and
initial patch is submitted by Mark Mason.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Mark Mason <mason@postdiluvian.org>
---
I thought about it more and marking up with ___cacheline_aligned seems
to be the right thing to do.  For older ones where ata_port is
allocated as part of scsi_host, I think what should be done is to
align private area of scsi_host to cacheline.  Will post another patch
for that.

Thanks.

 include/linux/libata.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
diff --git a/include/linux/libata.h b/include/linux/libata.h
index bc5a8d0..7604763 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -671,7 +671,8 @@ struct ata_port {
 	acpi_handle		acpi_handle;
 	struct ata_acpi_gtm	__acpi_init_gtm; /* use ata_acpi_init_gtm() */
 #endif
-	u8			sector_buf[ATA_SECT_SIZE]; /* owned by EH */
+	/* owned by EH, must be cache line aligned as it's used as DMA target */
+	u8			sector_buf[ATA_SECT_SIZE] ____cacheline_aligned;
 };
 
 struct ata_port_operations {

  reply	other threads:[~2008-02-14  9:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 18:02 libata/sata_sil24 cache alignment problem? Mark Mason
2008-02-12 22:12 ` Alan Cox
2008-02-12 23:36   ` James Bottomley
2008-02-13  2:13     ` Alan Cox
2008-02-13  2:32       ` James Bottomley
2008-02-13 18:47   ` Mark Mason
2008-02-13 20:21     ` Alan Cox
2008-02-13 21:25       ` Mark Mason
2008-02-14  0:21         ` Alan Cox
2008-02-14  3:05           ` Tejun Heo
2008-02-14  9:44             ` Tejun Heo [this message]
2008-02-14  9:48             ` [PATCH] scsi: align shost->hostdata to cacheline Tejun Heo
2008-02-14 15:05               ` James Bottomley
2008-02-14 22:49                 ` Tejun Heo
2008-02-15 18:57                   ` James Bottomley
2008-02-21  2:32                     ` Tejun Heo
2008-02-13 18:51   ` libata/sata_sil24 cache alignment problem? Mark Mason
2008-02-12 23:25 ` Thomas Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B40D63.6060507@gmail.com \
    --to=htejun@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jens.axboe@oracle.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mason@postdiluvian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).