From: Tejun Heo <htejun@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org,
jengelh@computergmbh.de, matthew@wil.cx, randy.dunlap@oracle.com,
daniel.ritz-ml@swissonline.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3
Date: Fri, 15 Feb 2008 12:16:48 +0900 [thread overview]
Message-ID: <47B50420.3060403@gmail.com> (raw)
In-Reply-To: <20080214185003.9ca9a640.akpm@linux-foundation.org>
Andrew Morton wrote:
>> So, I guess it's NACK w/o suggested alternatives, right?
>
> I wouldn't nack without good reasons, and I have none here. I don't have
> very strong opinions either way.
I was just wondering whether I should just go with snprintf dancing in
eh_link_report, which does make sense if not many need merging printk.
> As a seat-of-the-pants thing, it does seem to be a lot of core code to
> solve a fairly minor problem in (afaik) one remote place. But I haven't
> looked - perhaps there are other places which could be improved if such
> facilities were available.
Okay, I see. I'll look around and see whether there are other places
which can use it. I can think of a few in SCSI. Let's see.
Thanks.
--
tejun
next prev parent reply other threads:[~2008-02-15 3:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 9:09 [PATCHSET] printk: implement printk_header() and merging printk, take #3 Tejun Heo
2008-02-13 9:09 ` [PATCH 1/5] printk: keep log level on multiline messages Tejun Heo
2008-02-13 9:09 ` [PATCH 2/5] printk: implement [v]printk_header() Tejun Heo
2008-02-13 9:09 ` [PATCH 3/5] printk: implement merging printk Tejun Heo
2008-02-13 9:09 ` [PATCH 4/5] printk: add Documentation/printk.txt Tejun Heo
2008-02-13 9:09 ` [PATCH 5/5] libata: make libata use printk_header() and mprintk Tejun Heo
2008-02-13 23:57 ` [PATCHSET] printk: implement printk_header() and merging printk, take #3 Andrew Morton
2008-02-14 0:40 ` Tejun Heo
2008-02-14 1:09 ` Andrew Morton
2008-02-14 1:26 ` Tejun Heo
2008-02-15 1:49 ` Tejun Heo
2008-02-15 2:27 ` Andrew Morton
2008-02-15 2:36 ` Tejun Heo
2008-02-15 2:50 ` Andrew Morton
2008-02-15 3:16 ` Tejun Heo [this message]
2008-02-16 14:13 ` Mark Lord
2008-02-14 16:29 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B50420.3060403@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.ritz-ml@swissonline.ch \
--cc=jeff@garzik.org \
--cc=jengelh@computergmbh.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).