* [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure [not found] ` <20080213090159.GA21614@elte.hu> @ 2008-02-13 9:20 ` Tejun Heo 2008-02-13 9:24 ` Ingo Molnar 2008-02-15 18:52 ` Jeff Garzik 0 siblings, 2 replies; 3+ messages in thread From: Tejun Heo @ 2008-02-13 9:20 UTC (permalink / raw) To: Ingo Molnar Cc: Arjan van de Ven, linux-kernel, Linus Torvalds, Mark Lord, Jeff Garzik, Alan Cox, IDE/ATA development list ata_host_detach() detaches an attached port and shouldn't be called on a port which hasn't been attached yet. pata_legacy incorrectly calls ata_host_detach() on unattached port after initialization failure causing oops. Fix it. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Ingo Molnar <mingo@elte.hu> Cc: Arjan van de Ven <arjan@infradead.org> --- drivers/ata/pata_legacy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c index 333dc15..7383f19 100644 --- a/drivers/ata/pata_legacy.c +++ b/drivers/ata/pata_legacy.c @@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe) } } fail: - if (host) - ata_host_detach(host); platform_device_unregister(pdev); return ret; } ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure 2008-02-13 9:20 ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo @ 2008-02-13 9:24 ` Ingo Molnar 2008-02-15 18:52 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Ingo Molnar @ 2008-02-13 9:24 UTC (permalink / raw) To: Tejun Heo Cc: Arjan van de Ven, linux-kernel, Linus Torvalds, Mark Lord, Jeff Garzik, Alan Cox, IDE/ATA development list * Tejun Heo <htejun@gmail.com> wrote: > ata_host_detach() detaches an attached port and shouldn't be called on > a port which hasn't been attached yet. pata_legacy incorrectly calls > ata_host_detach() on unattached port after initialization failure > causing oops. Fix it. thanks, i'll try this! Ingo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure 2008-02-13 9:20 ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo 2008-02-13 9:24 ` Ingo Molnar @ 2008-02-15 18:52 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Jeff Garzik @ 2008-02-15 18:52 UTC (permalink / raw) To: Tejun Heo Cc: Ingo Molnar, Arjan van de Ven, linux-kernel, Linus Torvalds, Mark Lord, Alan Cox, IDE/ATA development list Tejun Heo wrote: > ata_host_detach() detaches an attached port and shouldn't be called on > a port which hasn't been attached yet. pata_legacy incorrectly calls > ata_host_detach() on unattached port after initialization failure > causing oops. Fix it. > > Signed-off-by: Tejun Heo <htejun@gmail.com> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Arjan van de Ven <arjan@infradead.org> > --- > drivers/ata/pata_legacy.c | 2 -- > 1 file changed, 2 deletions(-) applied ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-15 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.LFD.1.00.0802101603240.2920@woody.linux-foundation.org>
[not found] ` <20080212081816.GA17820@elte.hu>
[not found] ` <20080212071452.5c58ae6d@laptopd505.fenrus.org>
[not found] ` <20080213090159.GA21614@elte.hu>
2008-02-13 9:20 ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo
2008-02-13 9:24 ` Ingo Molnar
2008-02-15 18:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).