From: Mark Lord <liml@rtr.ca>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_mv: Define module alias for platform device
Date: Sat, 16 Feb 2008 12:22:28 -0500 [thread overview]
Message-ID: <47B71BD4.40503@rtr.ca> (raw)
In-Reply-To: <20080216171527.GA2552@deprecation.cyrius.com>
Martin Michlmayr wrote:
> The sata_mv driver can be loaded as a platform device, as is done by
> various Orion (ARM) based devices. The driver needs to define a module
> alias for the platform driver so udev will load it automatically.
> Tested with Debian on a QNAP TS-209.
>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
>
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -3198,6 +3198,7 @@ MODULE_DESCRIPTION("SCSI low-level driver for Marvell SATA controllers");
> MODULE_LICENSE("GPL");
> MODULE_DEVICE_TABLE(pci, mv_pci_tbl);
> MODULE_VERSION(DRV_VERSION);
> +MODULE_ALIAS("platform:sata_mv");
>
> #ifdef CONFIG_PCI
> module_param(msi, int, 0444);
>
..
Acked-by: Mark Lord <mlord@pobox.com>
Looks safe enough.
next prev parent reply other threads:[~2008-02-16 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 17:15 [PATCH] sata_mv: Define module alias for platform device Martin Michlmayr
2008-02-16 17:22 ` Mark Lord [this message]
2008-02-20 17:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B71BD4.40503@rtr.ca \
--to=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).