linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Jan Evert van Grootheest <j.e.van.grootheest@caiway.nl>
Cc: linux-ide@vger.kernel.org, bzolnier@gmail.com
Subject: Re: [PATCH ht6560b] Force prefetch for some devices
Date: Mon, 18 Feb 2008 16:58:52 +0300	[thread overview]
Message-ID: <47B98F1C.3050808@ru.mvista.com> (raw)
In-Reply-To: <47B97EFA.2040805@caiway.nl>

Hello.

Jan Evert van Grootheest wrote:

> Prefetch needs to be set for some ide devices to work when connected to

    Prefetch bit seems to mean 1=disable, 0=enable despite what the datasheet 
says...

> a ht6560b interface. This was not always done properly, causing a system
> with a HD and CD on the primary interface to not work properly. Or, in
> effect, hang hard.

> This patch forces prefetch on devices before checking whether it
> is necessary to change the settings in the interface

> This patch should also be applied to 2.4. I don't currently have a
> 2.4 tree around.

> (also change my email address)

> Signed-off-by: Jan Evert van Grootheest <janevert@caiway.nl>

    Please send the patch to the current 2.4 maintainer, after applying it to 
the 2.4 tree which you can download on kernel.org.

> ------------------------------------------------------------------------
> 
> --- linux-2.6.git/drivers/ide/legacy/ht6560b.c	2008-02-01 18:50:31.000000000 +0100
> +++ linux-2.6.24/drivers/ide/legacy/ht6560b.c	2008-02-18 13:48:59.000000000 +0100
> @@ -23,18 +23,21 @@
>   *                      "Prefetch" mode bit OFF for ide disks and
>   *                      ON for anything else.
>   *
> + *  Version 0.08        Need to force prefetch for CDs and other non-disk
> + *                      devices. (not sure which devices exactly need
> + *                      prefetch)
>   *

    Hard disks only ai guess, i.e. non-ATAPI device.

MBR, Sergei

  reply	other threads:[~2008-02-18 13:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 12:50 [PATCH ht6560b] Force prefetch for some devices Jan Evert van Grootheest
2008-02-18 13:58 ` Sergei Shtylyov [this message]
2008-02-18 14:36 ` Alan Cox
2008-02-18 15:21   ` Jan Evert van Grootheest
2008-02-18 15:47     ` Alan Cox
2008-06-27 19:51   ` Jan Evert van Grootheest
2008-06-27 20:04     ` Alan Cox
2008-02-18 23:14 ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B98F1C.3050808@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=j.e.van.grootheest@caiway.nl \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).