From: Mark Lord <liml@rtr.ca>
To: Albert Lee <albertcc@tw.ibm.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>, Alan Cox <alan@redhat.com>,
Tejun Heo <htejun@gmail.com>
Subject: atapi_dmadir: why do we not (also) auto-detect it from IDENTIFY PACKET ??
Date: Mon, 18 Feb 2008 14:02:36 -0500 [thread overview]
Message-ID: <47B9D64C.3000705@rtr.ca> (raw)
Albert / Jeff,
Way back in 2.6.17-rc2, you guys signed-off on 95de719adc94392a95c3c4d0a2d6b8b1ea39d236,
which added a libata module parameter for atapi_dmadir.
That's nice, but many modern drives (or bridge chips) flag this in
their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data.
So for those at lease, we should be automatically setting atapi_dmadir=1.
But on a per-device basis, not globally as done now.
Albert: do you want to cook up a bug fix for this?
Cheers
next reply other threads:[~2008-02-18 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 19:02 Mark Lord [this message]
2008-02-18 20:53 ` [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it Mark Lord
2008-02-18 22:20 ` Alan Cox
2008-02-19 0:41 ` Mark Lord
2008-02-20 17:18 ` Jeff Garzik
2008-02-20 18:53 ` Mark Lord
2008-02-21 4:25 ` [PATCH] libata: " Tejun Heo
2008-02-22 10:09 ` Albert Lee
2008-02-22 13:33 ` Mark Lord
2008-02-22 14:11 ` Mark Lord
2008-02-22 16:32 ` Jeff Garzik
2008-02-24 5:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B9D64C.3000705@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@redhat.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).