From: Jeff Garzik <jeff@garzik.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.osdl.org>,
linux-ide@vger.kernel.org
Subject: Re: power_state: get rid of write-only variable in SATA
Date: Sun, 24 Feb 2008 00:29:20 -0500 [thread overview]
Message-ID: <47C100B0.1040408@garzik.org> (raw)
In-Reply-To: <20080221125652.GA23548@elf.ucw.cz>
Pavel Machek wrote:
> power_state is scheduled for removal, and libata uses it in write-only
> mode. Remove it.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b4985bc..a31572d 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6542,8 +6542,6 @@ int ata_host_suspend(struct ata_host *ho
> ata_lpm_enable(host);
>
> rc = ata_host_request_pm(host, mesg, 0, ATA_EHI_QUIET, 1);
> - if (rc == 0)
> - host->dev->power.power_state = mesg;
> return rc;
> }
>
> @@ -6562,7 +6560,6 @@ void ata_host_resume(struct ata_host *ho
> {
> ata_host_request_pm(host, PMSG_ON, ATA_EH_SOFTRESET,
> ATA_EHI_NO_AUTOPSY | ATA_EHI_QUIET, 0);
> - host->dev->power.power_state = PMSG_ON;
>
applied
prev parent reply other threads:[~2008-02-24 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 12:56 power_state: get rid of write-only variable in SATA Pavel Machek
2008-02-21 16:09 ` Jeff Garzik
2008-02-21 19:33 ` [linux-pm] " David Brownell
2008-02-21 23:42 ` Pavel Machek
2008-02-24 5:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C100B0.1040408@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).