* [PATCH] AMD SB700/SB800 SATA support 64bit DMA
@ 2008-02-22 4:55 Huang, Shane
2008-02-22 4:59 ` Tejun Heo
2008-02-22 9:32 ` Alan Cox
0 siblings, 2 replies; 9+ messages in thread
From: Huang, Shane @ 2008-02-22 4:55 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, Tejun Heo, Su, Henry, Huang, Shane
Jeff:
SB700 SATA controller can support 64 bit DMA, the previous commit
badc2341579511a247f5993865aa68379e283c5c was added with
careless reference to SB600, which should be modified by this patch.
Signed-off-by: Shane Huang <shane.huang@amd.com>
diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
--- a/drivers/ata/ahci.c 2008-02-22 18:17:03.000000000 +0800
+++ b/drivers/ata/ahci.c 2008-02-22 18:16:54.000000000 +0800
@@ -85,6 +85,7 @@
board_ahci_ign_iferr = 2,
board_ahci_sb600 = 3,
board_ahci_mv = 4,
+ board_ahci_sb700 = 5,
/* global controller registers */
HOST_CAP = 0x00, /* host capabilities */
@@ -442,6 +443,16 @@
.udma_mask = ATA_UDMA6,
.port_ops = &ahci_ops,
},
+ /* board_ahci_sb700 */
+ {
+ AHCI_HFLAGS (AHCI_HFLAG_IGN_SERR_INTERNAL |
+ AHCI_HFLAG_NO_PMP),
+ .flags = AHCI_FLAG_COMMON,
+ .link_flags = AHCI_LFLAG_COMMON,
+ .pio_mask = 0x1f, /* pio0-4 */
+ .udma_mask = ATA_UDMA6,
+ .port_ops = &ahci_ops,
+ },
};
static const struct pci_device_id ahci_pci_tbl[] = {
@@ -484,12 +495,12 @@
/* ATI */
{ PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 */
- { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700/800
*/
- { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb600 }, /* ATI SB700/800
*/
- { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb600 }, /* ATI SB700/800
*/
- { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb600 }, /* ATI SB700/800
*/
- { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb600 }, /* ATI SB700/800
*/
- { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb600 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb700 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb700 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb700 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb700 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb700 }, /* ATI SB700/800
*/
+ { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb700 }, /* ATI SB700/800
*/
/* VIA */
{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251
*/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 4:55 Huang, Shane
@ 2008-02-22 4:59 ` Tejun Heo
2008-02-22 5:08 ` Huang, Shane
2008-02-22 9:32 ` Alan Cox
1 sibling, 1 reply; 9+ messages in thread
From: Tejun Heo @ 2008-02-22 4:59 UTC (permalink / raw)
To: Huang, Shane; +Cc: jgarzik, linux-ide, Su, Henry
Huang, Shane wrote:
> Jeff:
>
> SB700 SATA controller can support 64 bit DMA, the previous commit
> badc2341579511a247f5993865aa68379e283c5c was added with
> careless reference to SB600, which should be modified by this patch.
>
>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
Shane, it still wraps. Just give up outlook and use thunderbird +
toggle wordwrap + external editor or mutt/pine.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 4:59 ` Tejun Heo
@ 2008-02-22 5:08 ` Huang, Shane
2008-02-22 5:16 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Huang, Shane @ 2008-02-22 5:08 UTC (permalink / raw)
To: Tejun Heo; +Cc: jgarzik, linux-ide, Su, Henry
OMG, but I modified my settings and verified that the patch can really
work here before I sent it to you...
Shane
> -----Original Message-----
> From: Tejun Heo [mailto:htejun@gmail.com]
> Sent: Friday, February 22, 2008 12:59 PM
> To: Huang, Shane
> Cc: jgarzik@pobox.com; linux-ide@vger.kernel.org; Su, Henry
> Subject: Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
>
> Huang, Shane wrote:
> > Jeff:
> >
> > SB700 SATA controller can support 64 bit DMA, the previous commit
> > badc2341579511a247f5993865aa68379e283c5c was added with
> > careless reference to SB600, which should be modified by this patch.
> >
> >
> > Signed-off-by: Shane Huang <shane.huang@amd.com>
>
> Shane, it still wraps. Just give up outlook and use thunderbird +
> toggle wordwrap + external editor or mutt/pine.
>
> --
> tejun
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 5:08 ` Huang, Shane
@ 2008-02-22 5:16 ` Jeff Garzik
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2008-02-22 5:16 UTC (permalink / raw)
To: Huang, Shane; +Cc: Tejun Heo, linux-ide, Su, Henry
Huang, Shane wrote:
> OMG, but I modified my settings and verified that the patch can really
> work here before I sent it to you...
It's word-wrapping, and also quoting a bunch of characters, which make
it difficult for tools to pick up:
> @ -85,6 +85,7 @@
> board_ahci_ign_iferr =3D 2,
> board_ahci_sb600 =3D 3,
> board_ahci_mv =3D 4,
> + board_ahci_sb700 =3D 5,
> =20
That "=3D" and "=20" stuff was added by your mailer (normal MIME email
quoted-printable quoting)
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 4:55 Huang, Shane
2008-02-22 4:59 ` Tejun Heo
@ 2008-02-22 9:32 ` Alan Cox
2008-02-22 11:03 ` Huang, Shane
1 sibling, 1 reply; 9+ messages in thread
From: Alan Cox @ 2008-02-22 9:32 UTC (permalink / raw)
Cc: jgarzik, linux-ide, Tejun Heo, Su, Henry, Huang, Shane
On Fri, 22 Feb 2008 12:55:20 +0800
"Huang, Shane" <Shane.Huang@amd.com> wrote:
> Jeff:
>
> SB700 SATA controller can support 64 bit DMA, the previous commit
> badc2341579511a247f5993865aa68379e283c5c was added with
> careless reference to SB600, which should be modified by this patch.
Does the SB700 have the same limits as the SB600 on 256 sectors in one
PRD entry ? If it does then this change needs to wait until the
workaround for that is included.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 9:32 ` Alan Cox
@ 2008-02-22 11:03 ` Huang, Shane
0 siblings, 0 replies; 9+ messages in thread
From: Huang, Shane @ 2008-02-22 11:03 UTC (permalink / raw)
To: Alan Cox; +Cc: jgarzik, linux-ide, Tejun Heo, Su, Henry, Huang, Shane
Alan:
> > SB700 SATA controller can support 64 bit DMA, the previous commit
> > badc2341579511a247f5993865aa68379e283c5c was added with
> > careless reference to SB600, which should be modified by this patch.
>
> Does the SB700 have the same limits as the SB600 on 256 sectors in one
> PRD entry ? If it does then this change needs to wait until the
> workaround for that is included.
Thanks for the reminder, but that issue only appears on SB600,
while SB700 does not have that limitation. I'll submit this
SB700/800 patch again with a private mail box later.
Thanks
Shane
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
@ 2008-02-22 13:00 Shane Huang
2008-02-23 0:45 ` Tejun Heo
2008-02-24 5:30 ` Jeff Garzik
0 siblings, 2 replies; 9+ messages in thread
From: Shane Huang @ 2008-02-22 13:00 UTC (permalink / raw)
To: jgarzik, htejun; +Cc: linux-ide, henry.su, shane.huang, ati.shane
Jeff and Tejun:
I'm using my private mailbox to submit it before I set up
the connection to our exchange mail server under linux.
Please check whether this patch can be accepted.
Thanks
Shane
CUT HERE
========
SB700 SATA controller can support 64 bit DMA, the previous commit
badc2341579511a247f5993865aa68379e283c5c was added with
careless reference to SB600, which should be modified by this patch.
Signed-off-by: Shane Huang <shane.huang@amd.com>
diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
--- a/drivers/ata/ahci.c 2008-02-22 18:17:03.000000000 +0800
+++ b/drivers/ata/ahci.c 2008-02-22 18:16:54.000000000 +0800
@@ -85,6 +85,7 @@
board_ahci_ign_iferr = 2,
board_ahci_sb600 = 3,
board_ahci_mv = 4,
+ board_ahci_sb700 = 5,
/* global controller registers */
HOST_CAP = 0x00, /* host capabilities */
@@ -442,6 +443,16 @@
.udma_mask = ATA_UDMA6,
.port_ops = &ahci_ops,
},
+ /* board_ahci_sb700 */
+ {
+ AHCI_HFLAGS (AHCI_HFLAG_IGN_SERR_INTERNAL |
+ AHCI_HFLAG_NO_PMP),
+ .flags = AHCI_FLAG_COMMON,
+ .link_flags = AHCI_LFLAG_COMMON,
+ .pio_mask = 0x1f, /* pio0-4 */
+ .udma_mask = ATA_UDMA6,
+ .port_ops = &ahci_ops,
+ },
};
static const struct pci_device_id ahci_pci_tbl[] = {
@@ -484,12 +495,12 @@
/* ATI */
{ PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 */
- { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700/800 */
- { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb600 }, /* ATI SB700/800 */
- { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb600 }, /* ATI SB700/800 */
- { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb600 }, /* ATI SB700/800 */
- { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb600 }, /* ATI SB700/800 */
- { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb600 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb700 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb700 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb700 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb700 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb700 }, /* ATI SB700/800 */
+ { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb700 }, /* ATI SB700/800 */
/* VIA */
{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 13:00 [PATCH] AMD SB700/SB800 SATA support 64bit DMA Shane Huang
@ 2008-02-23 0:45 ` Tejun Heo
2008-02-24 5:30 ` Jeff Garzik
1 sibling, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2008-02-23 0:45 UTC (permalink / raw)
To: Shane Huang; +Cc: jgarzik, linux-ide, henry.su, shane.huang
Shane Huang wrote:
> Jeff and Tejun:
>
>
> I'm using my private mailbox to submit it before I set up
> the connection to our exchange mail server under linux.
> Please check whether this patch can be accepted.
Patch looks fine to me.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
2008-02-22 13:00 [PATCH] AMD SB700/SB800 SATA support 64bit DMA Shane Huang
2008-02-23 0:45 ` Tejun Heo
@ 2008-02-24 5:30 ` Jeff Garzik
1 sibling, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2008-02-24 5:30 UTC (permalink / raw)
To: Shane Huang; +Cc: htejun, linux-ide, henry.su, shane.huang
Shane Huang wrote:
> Jeff and Tejun:
>
>
> I'm using my private mailbox to submit it before I set up
> the connection to our exchange mail server under linux.
> Please check whether this patch can be accepted.
>
>
> Thanks
> Shane
>
>
> CUT HERE
> ========
> SB700 SATA controller can support 64 bit DMA, the previous commit
> badc2341579511a247f5993865aa68379e283c5c was added with
> careless reference to SB600, which should be modified by this patch.
>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
applied
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-02-24 5:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-22 13:00 [PATCH] AMD SB700/SB800 SATA support 64bit DMA Shane Huang
2008-02-23 0:45 ` Tejun Heo
2008-02-24 5:30 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-02-22 4:55 Huang, Shane
2008-02-22 4:59 ` Tejun Heo
2008-02-22 5:08 ` Huang, Shane
2008-02-22 5:16 ` Jeff Garzik
2008-02-22 9:32 ` Alan Cox
2008-02-22 11:03 ` Huang, Shane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).