From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
Alan Cox <alan@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
IDE/ATA development list <linux-ide>
Subject: libata .sg_tablesize: why always dividing by 2 ?
Date: Mon, 25 Feb 2008 19:02:53 -0500 [thread overview]
Message-ID: <47C3572D.1060904@rtr.ca> (raw)
Jeff,
We had a discussion here today about IOMMUs,
and they *never* split sg list entries -- they only ever *merge*.
And this happens only after the block layer has
already done merging while respecting q->seg_boundary_mask.
So worst case, the IOMMU may merge everything, and then in
libata we unmerge them again. But the end result can never
exceed the max_sg_entries limit enforced by the block layer.
So.. why are we still specifying .sg_tablesize as half of
what the LLD can really handle?
This can cost a lot of memory, as using NCQ effectively multiplies
everything by 32..
Based on this information, I should be able to do this in sata_mv,
for example:
- .sg_tablesize = MV_MAX_SG_CT / 2,
+ .sg_tablesize = MV_MAX_SG_CT,
???
next reply other threads:[~2008-02-26 0:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 0:02 Mark Lord [this message]
2008-02-26 0:15 ` libata .sg_tablesize: why always dividing by 2 ? Jeff Garzik
2008-02-26 0:27 ` Mark Lord
2008-02-26 0:54 ` Benjamin Herrenschmidt
2008-02-26 1:37 ` Mark Lord
2008-02-26 1:43 ` Mark Lord
2008-02-26 2:54 ` Benjamin Herrenschmidt
2008-02-26 4:38 ` Mark Lord
2008-02-26 5:30 ` Benjamin Herrenschmidt
2008-02-26 5:43 ` Mark Lord
2008-02-26 5:47 ` Benjamin Herrenschmidt
2008-02-26 16:09 ` James Bottomley
2008-02-26 21:43 ` Benjamin Herrenschmidt
2008-02-26 16:25 ` Mark Lord
2008-02-26 16:51 ` Mark Lord
2008-02-26 21:50 ` Benjamin Herrenschmidt
2008-02-26 21:56 ` James Bottomley
2008-02-26 22:30 ` Benjamin Herrenschmidt
2008-02-26 23:16 ` Benjamin Herrenschmidt
2008-02-26 21:43 ` Benjamin Herrenschmidt
2008-02-26 23:07 ` Alan Cox
2008-02-26 23:19 ` Benjamin Herrenschmidt
2008-02-28 7:36 ` FUJITA Tomonori
2008-02-28 7:44 ` Benjamin Herrenschmidt
2008-02-26 2:52 ` Benjamin Herrenschmidt
2008-02-26 0:22 ` Jeff Garzik
2008-02-26 0:28 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C3572D.1060904@rtr.ca \
--to=liml@rtr.ca \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@redhat.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).