From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: ops->qc_defer not invoked on ata_exec_internal_sg() paths ? Date: Tue, 26 Feb 2008 10:47:42 -0500 Message-ID: <47C4349E.5010802@rtr.ca> References: <47C35B6B.8000406@rtr.ca> <20080226123209.7ca9eed4@core> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:3032 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759684AbYBZPor (ORCPT ); Tue, 26 Feb 2008 10:44:47 -0500 In-Reply-To: <20080226123209.7ca9eed4@core> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Tejun Heo , IDE/ATA development list Alan Cox wrote: > On Mon, 25 Feb 2008 19:20:59 -0500 > Mark Lord wrote: > >> The optional .qc_defer() methods don't seem to be called >> on the ata_exec_internal_sg() path. >> >> At present, this is probably okay. But in the future, >> as we add functionality for link power management >> and hotplug polling, this could be a problem. > > It becomes a problem for me certainly if we ever issue anything via > exec_internal_sg while another command may be outstanding anywhere on the > same *host*. Right now its ok. .. Yeah, for serializing a pair of ATA channels on the same host chip. -ml