* ops->qc_defer not invoked on ata_exec_internal_sg() paths ?
@ 2008-02-26 0:20 Mark Lord
2008-02-26 1:37 ` Tejun Heo
2008-02-26 12:32 ` Alan Cox
0 siblings, 2 replies; 4+ messages in thread
From: Mark Lord @ 2008-02-26 0:20 UTC (permalink / raw)
To: Tejun Heo, IDE/ATA development list
The optional .qc_defer() methods don't seem to be called
on the ata_exec_internal_sg() path.
At present, this is probably okay. But in the future,
as we add functionality for link power management
and hotplug polling, this could be a problem.
I think. Or is it possibly also a problem today
for sata_send_pmp() and friends ?
Tejun?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ops->qc_defer not invoked on ata_exec_internal_sg() paths ?
2008-02-26 0:20 ops->qc_defer not invoked on ata_exec_internal_sg() paths ? Mark Lord
@ 2008-02-26 1:37 ` Tejun Heo
2008-02-26 12:32 ` Alan Cox
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2008-02-26 1:37 UTC (permalink / raw)
To: Mark Lord; +Cc: IDE/ATA development list
Hello, Mark.
Mark Lord wrote:
> The optional .qc_defer() methods don't seem to be called
> on the ata_exec_internal_sg() path.
>
> At present, this is probably okay. But in the future,
> as we add functionality for link power management
> and hotplug polling, this could be a problem.
>
> I think. Or is it possibly also a problem today
> for sata_send_pmp() and friends ?
That's intentional and okay. Currently, EH can only issue one non-NCQ
command at a time and dynamic link PM and hotplug polling shouldn't be
done via EH anyway. EH is way too big a hammer for those.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ops->qc_defer not invoked on ata_exec_internal_sg() paths ?
2008-02-26 0:20 ops->qc_defer not invoked on ata_exec_internal_sg() paths ? Mark Lord
2008-02-26 1:37 ` Tejun Heo
@ 2008-02-26 12:32 ` Alan Cox
2008-02-26 15:47 ` Mark Lord
1 sibling, 1 reply; 4+ messages in thread
From: Alan Cox @ 2008-02-26 12:32 UTC (permalink / raw)
To: Mark Lord; +Cc: Tejun Heo, IDE/ATA development list
On Mon, 25 Feb 2008 19:20:59 -0500
Mark Lord <liml@rtr.ca> wrote:
> The optional .qc_defer() methods don't seem to be called
> on the ata_exec_internal_sg() path.
>
> At present, this is probably okay. But in the future,
> as we add functionality for link power management
> and hotplug polling, this could be a problem.
It becomes a problem for me certainly if we ever issue anything via
exec_internal_sg while another command may be outstanding anywhere on the
same *host*. Right now its ok.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ops->qc_defer not invoked on ata_exec_internal_sg() paths ?
2008-02-26 12:32 ` Alan Cox
@ 2008-02-26 15:47 ` Mark Lord
0 siblings, 0 replies; 4+ messages in thread
From: Mark Lord @ 2008-02-26 15:47 UTC (permalink / raw)
To: Alan Cox; +Cc: Tejun Heo, IDE/ATA development list
Alan Cox wrote:
> On Mon, 25 Feb 2008 19:20:59 -0500
> Mark Lord <liml@rtr.ca> wrote:
>
>> The optional .qc_defer() methods don't seem to be called
>> on the ata_exec_internal_sg() path.
>>
>> At present, this is probably okay. But in the future,
>> as we add functionality for link power management
>> and hotplug polling, this could be a problem.
>
> It becomes a problem for me certainly if we ever issue anything via
> exec_internal_sg while another command may be outstanding anywhere on the
> same *host*. Right now its ok.
..
Yeah, for serializing a pair of ATA channels on the same host chip.
-ml
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-26 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-26 0:20 ops->qc_defer not invoked on ata_exec_internal_sg() paths ? Mark Lord
2008-02-26 1:37 ` Tejun Heo
2008-02-26 12:32 ` Alan Cox
2008-02-26 15:47 ` Mark Lord
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).