From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Mark Lord <liml@rtr.ca>, Matthew Wilcox <matthew@wil.cx>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] libata: kill SCSI devices before detaching ata_host
Date: Fri, 07 Mar 2008 12:11:50 +0900 [thread overview]
Message-ID: <47D0B276.1010301@gmail.com> (raw)
In-Reply-To: <47D0B1A4.2040104@gmail.com>
Kill SCSI devices before detaching port. This makes drives properly
shut down on driver unload.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-core.c | 8 ++++++++
1 file changed, 8 insertions(+)
Index: work1/drivers/ata/libata-core.c
===================================================================
--- work1.orig/drivers/ata/libata-core.c
+++ work1/drivers/ata/libata-core.c
@@ -7236,6 +7236,14 @@ static void ata_port_detach(struct ata_p
if (!ap->ops->error_handler)
goto skip_eh;
+ /* First, tell all SCSI devices that we're going down. Note
+ * that there's a small race window here. Devices which get
+ * hotplugged after forget_host but before EH is killed won't
+ * get shut down by SCSI layer properly and will miss cache
+ * flush and spin down.
+ */
+ scsi_forget_host(ap->scsi_host);
+
/* tell EH we're leaving & flush EH */
spin_lock_irqsave(ap->lock, flags);
ap->pflags |= ATA_PFLAG_UNLOADING;
next prev parent reply other threads:[~2008-03-07 3:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 20:09 ata_ram driver Matthew Wilcox
2008-02-22 21:27 ` Mark Lord
2008-03-06 8:21 ` Tejun Heo
2008-03-06 15:28 ` James Bottomley
2008-03-06 23:55 ` Tejun Heo
2008-03-07 0:01 ` James Bottomley
2008-03-07 0:13 ` Tejun Heo
2008-03-07 0:22 ` James Bottomley
2008-03-07 0:28 ` Tejun Heo
2008-03-07 0:39 ` James Bottomley
2008-03-07 0:43 ` Tejun Heo
2008-03-07 3:08 ` [PATCH 1/2] scsi: export scsi_forget_host() Tejun Heo
2008-03-07 3:11 ` Tejun Heo [this message]
2008-03-07 2:16 ` ata_ram driver Jeff Garzik
2008-03-07 2:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D0B276.1010301@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).