* [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config()
@ 2008-03-09 20:42 Roel Kluin
2008-03-10 11:42 ` Tejun Heo
2008-03-11 0:52 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2008-03-09 20:42 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, lkml
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 8a49835..1b73307 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -672,7 +672,7 @@ static void ahci_save_initial_config(struct pci_dev *pdev,
cap &= ~HOST_CAP_NCQ;
}
- if ((cap && HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
+ if ((cap & HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
dev_printk(KERN_INFO, &pdev->dev,
"controller can't do PMP, turning off CAP_PMP\n");
cap &= ~HOST_CAP_PMP;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config()
2008-03-09 20:42 [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config() Roel Kluin
@ 2008-03-10 11:42 ` Tejun Heo
2008-03-11 0:52 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2008-03-10 11:42 UTC (permalink / raw)
To: Roel Kluin; +Cc: Jeff Garzik, linux-ide, lkml
Roel Kluin wrote:
> logical-bitwise & confusion
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Tejun Heo <htejun@gmail.com>
Thanks for spotting this.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config()
2008-03-09 20:42 [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config() Roel Kluin
2008-03-10 11:42 ` Tejun Heo
@ 2008-03-11 0:52 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-03-11 0:52 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-ide, lkml
Roel Kluin wrote:
> logical-bitwise & confusion
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 8a49835..1b73307 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -672,7 +672,7 @@ static void ahci_save_initial_config(struct pci_dev *pdev,
> cap &= ~HOST_CAP_NCQ;
> }
>
> - if ((cap && HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
> + if ((cap & HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
> dev_printk(KERN_INFO, &pdev->dev,
> "controller can't do PMP, turning off CAP_PMP\n");
> cap &= ~HOST_CAP_PMP;
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-11 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-09 20:42 [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config() Roel Kluin
2008-03-10 11:42 ` Tejun Heo
2008-03-11 0:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).