From: Jeff Garzik <jgarzik@pobox.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config()
Date: Mon, 10 Mar 2008 20:52:11 -0400 [thread overview]
Message-ID: <47D5D7BB.1070206@pobox.com> (raw)
In-Reply-To: <47D44BC0.2090906@tiscali.nl>
Roel Kluin wrote:
> logical-bitwise & confusion
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 8a49835..1b73307 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -672,7 +672,7 @@ static void ahci_save_initial_config(struct pci_dev *pdev,
> cap &= ~HOST_CAP_NCQ;
> }
>
> - if ((cap && HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
> + if ((cap & HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
> dev_printk(KERN_INFO, &pdev->dev,
> "controller can't do PMP, turning off CAP_PMP\n");
> cap &= ~HOST_CAP_PMP;
applied
prev parent reply other threads:[~2008-03-11 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 20:42 [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config() Roel Kluin
2008-03-10 11:42 ` Tejun Heo
2008-03-11 0:52 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5D7BB.1070206@pobox.com \
--to=jgarzik@pobox.com \
--cc=12o3l@tiscali.nl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).