From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/4] ide: sanitize handling of IDE_HFLAG_NO_SET_MODE host flag Date: Wed, 12 Mar 2008 19:45:49 +0300 Message-ID: <47D808BD.2080902@ru.mvista.com> References: <200802232115.11908.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:16051 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751766AbYCLQoc (ORCPT ); Wed, 12 Mar 2008 12:44:32 -0400 In-Reply-To: <200802232115.11908.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > * Check for IDE_HFLAG_NO_SET_MODE host flag in ide_set_pio(), > ide_set_[pio,dma]_mode(), ide_set_xfer_rate() and set_pio_mode(). > * Remove no longer needed IDE_HFLAG_NO_SET_MODE host flag checking > from ide_tune_dma(). > * Remove superfluous ->set_pio_mode checking from do_special(). > This is a part of preparations for adding 'struct ide_port_ops'. > Signed-off-by: Bartlomiej Zolnierkiewicz > Index: b/drivers/ide/ide-lib.c > =================================================================== > --- a/drivers/ide/ide-lib.c > +++ b/drivers/ide/ide-lib.c > @@ -353,6 +354,9 @@ int ide_set_pio_mode(ide_drive_t *drive, > { > ide_hwif_t *hwif = drive->hwif; > > + if (hwif->host_flags & IDE_HFLAG_NO_SET_MODE) > + return 0; > + Shouldn't this be considered an error? > if (hwif->set_pio_mode == NULL) > return -1; > > @@ -380,6 +384,9 @@ int ide_set_dma_mode(ide_drive_t *drive, > { > ide_hwif_t *hwif = drive->hwif; > > + if (hwif->host_flags & IDE_HFLAG_NO_SET_MODE) > + return 0; > + Same here.... > if (hwif->set_dma_mode == NULL) > return -1; > > @@ -410,7 +417,8 @@ int ide_set_xfer_rate(ide_drive_t *drive > { > ide_hwif_t *hwif = drive->hwif; > > - if (hwif->set_dma_mode == NULL) > + if (hwif->set_dma_mode == NULL || > + (hwif->host_flags & IDE_HFLAG_NO_SET_MODE)) > return -1; Hm, this is was not considered an error before... MBR, Sergei