From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: PCI device should be powered up before being accessed
Date: Mon, 17 Mar 2008 08:24:32 -0400 [thread overview]
Message-ID: <47DE6300.4070004@garzik.org> (raw)
In-Reply-To: <47D667DA.8050905@gmail.com>
Tejun Heo wrote:
> PCI device should be powered up or powered up before its PCI regsiters
> are accessed. Although PCI configuration register access is allowed
> in D3hot, PCI device is free to reset its status when transiting from
> D3hot to D0 causing configuration data to change.
>
> Many libata SFF drivers which use ata_pci_init_one() read and update
> configuration registers before calling ata_pci_init_one() which
> enables the PCI device. Also, in resume paths, some drivers access
> registers without resuming the PCI device.
>
> This patch adds a call to pcim_enable_device() in init path if
> register is accessed before calling ata_pci_init_one() and make resume
> paths first resume PCI devices, access PCI configuration regiters then
> resume ATA host.
>
> While at it...
>
> * cmd640 was strange in that it set ->resume even when CONFIG_PM is
> not. This is by-product of minimal build fix. Updated.
>
> * In cs5530, Don't BUG() on reinit failure. Just whine and fail
> resume.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/pata_ali.c | 14 +++++++++++++-
> drivers/ata/pata_amd.c | 16 +++++++++++++++-
> drivers/ata/pata_artop.c | 5 +++++
> drivers/ata/pata_cmd640.c | 21 ++++++++++++++++-----
> drivers/ata/pata_cmd64x.c | 15 ++++++++++++++-
> drivers/ata/pata_cs5520.c | 15 ++++++++++++++-
> drivers/ata/pata_cs5530.c | 18 ++++++++++++++++--
> drivers/ata/pata_hpt366.c | 14 +++++++++++++-
> drivers/ata/pata_hpt37x.c | 5 +++++
> drivers/ata/pata_hpt3x2n.c | 5 +++++
> drivers/ata/pata_it821x.c | 14 +++++++++++++-
> drivers/ata/pata_netcell.c | 5 +++++
> drivers/ata/pata_ns87415.c | 6 ++++++
> drivers/ata/pata_optidma.c | 5 +++++
> drivers/ata/pata_serverworks.c | 19 ++++++++++++++++---
> drivers/ata/pata_sil680.c | 13 +++++++++++--
> drivers/ata/pata_sis.c | 6 +++++-
> drivers/ata/pata_sl82c105.c | 5 +++++
> drivers/ata/pata_via.c | 14 +++++++++++++-
> 19 files changed, 195 insertions(+), 20 deletions(-)
Did Alan ACK this?
Can this wait until 2.6.26, or is it important for 2.6.25?
next prev parent reply other threads:[~2008-03-17 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 11:07 [PATCH libata-dev#upstream-fixes] libata: PCI device should be powered up before being accessed Tejun Heo
2008-03-17 12:24 ` Jeff Garzik [this message]
2008-03-17 12:35 ` Tejun Heo
2008-03-17 15:00 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DE6300.4070004@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).