From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/1] IDE: fix ide.h compiler warning
Date: Fri, 21 Mar 2008 21:10:29 +0300 [thread overview]
Message-ID: <47E3FA15.9000008@ru.mvista.com> (raw)
In-Reply-To: <200803181419.08687.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] ide: do complete DMA setup in ->init_dma method (take 2)
> * Make ide_hwif_setup_dma() return an error value.
> * Pass 'const struct ide_port_info *d' instead of 'unsigned long dmabase'
> to ->init_dma method and make it return an error value.
> * Rename ide_get_or_set_dma_base() to ide_pci_dma_base(),
> change ordering of its arguments and then export it.
> * Export ide_pci_set_master().
> * Do complete DMA setup inside ->init_dma method and update ->init_dma
> users accordingly.
> * Sanitize code for DMA setup in ide_init_port().
> v2:
> * Fix for CONFIG_BLK_DEV_IDEDMA_PCI=n configs
> (from Jiri Slaby <jirislaby@gmail.com>):
> Fix following compiler warning by returning EINVAL:
> In file included from ANYTHING-INCLUDING-IDE.H:45:
> include/linux/ide.h: In function ‘ide_hwif_setup_dma’:
> include/linux/ide.h:1022: warning: no return statement in function returning non-void
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2008-03-21 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1205683318-1409-1-git-send-email-jirislaby@gmail.com>
2008-03-18 13:19 ` [PATCH 1/1] IDE: fix ide.h compiler warning Bartlomiej Zolnierkiewicz
2008-03-21 18:10 ` Sergei Shtylyov [this message]
2008-03-16 16:02 Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E3FA15.9000008@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).