* [PATCH #upstream-fixes] libata: improve HPA error handling
@ 2008-03-23 12:05 Tejun Heo
2008-03-25 2:25 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-03-23 12:05 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list; +Cc: Alan Cox
There's no point in retrying and eventually failing device detection
when the device rejects READ_NATIVE_MAX[_EXT]. Disable HPA unlocking
if READ_NATIVE_MAX[_EXT] is rejected as done when SET_MAX[_EXT] is
rejected.
This allows some old drives to work even if they aren't blacklisted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4bbe31f..db1c65c 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1416,12 +1416,12 @@ static int ata_hpa_resize(struct ata_device *dev)
/* read native max address */
rc = ata_read_native_max_address(dev, &native_sectors);
if (rc) {
- /* If HPA isn't going to be unlocked, skip HPA
- * resizing from the next try.
+ /* If device aborted the command or HPA isn't going to
+ * be unlocked, skip HPA resizing.
*/
- if (!ata_ignore_hpa) {
+ if (rc == -EACCES || !ata_ignore_hpa) {
ata_dev_printk(dev, KERN_WARNING, "HPA support seems "
- "broken, will skip HPA handling\n");
+ "broken, skipping HPA handling\n");
dev->horkage |= ATA_HORKAGE_BROKEN_HPA;
/* we can continue if device aborted the command */
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream-fixes] libata: improve HPA error handling
2008-03-23 12:05 [PATCH #upstream-fixes] libata: improve HPA error handling Tejun Heo
@ 2008-03-25 2:25 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-03-25 2:25 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, Alan Cox
Tejun Heo wrote:
> There's no point in retrying and eventually failing device detection
> when the device rejects READ_NATIVE_MAX[_EXT]. Disable HPA unlocking
> if READ_NATIVE_MAX[_EXT] is rejected as done when SET_MAX[_EXT] is
> rejected.
>
> This allows some old drives to work even if they aren't blacklisted.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-25 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-23 12:05 [PATCH #upstream-fixes] libata: improve HPA error handling Tejun Heo
2008-03-25 2:25 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).