* [PATCH #upstream] pata_scc: fix compile warning [not found] <20080327151331.e11d3665.sfr@canb.auug.org.au> @ 2008-03-27 10:44 ` Tejun Heo 2008-04-04 7:40 ` Jeff Garzik 0 siblings, 1 reply; 2+ messages in thread From: Tejun Heo @ 2008-03-27 10:44 UTC (permalink / raw) To: Stephen Rothwell; +Cc: Jeff Garzik, linux-next, IDE/ATA development list Missed one during mass conversion (dc14c0c5). Fix it. Spotted by Stephen Rothwell. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> --- Stephen Rothwell wrote: > Hi Jeff, Tejun (Heo? I am sorry if I chose the wrong name), Yeap, Tejun is fine. > Today's build of linux-next produces this warning: > > drivers/ata/pata_scc.c:1002: warning: initialization discards qualifiers from pointer target type > > Presumably caused by commit dc14c0c5012855bfc9a5f76056b92f198d52834c > ("libata: implement and use ops inheritance"). Thanks for spotting this. I couldn't compile test platform specific ones. Hmm... pata_scc doesn't seem to have platform dependencies, maybe we can drop PPC_CELLEB dependency. drivers/ata/pata_scc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c index 07f2d7a..f6a6ce1 100644 --- a/drivers/ata/pata_scc.c +++ b/drivers/ata/pata_scc.c @@ -960,7 +960,7 @@ static struct scsi_host_template scc_sht = { ATA_BMDMA_SHT(DRV_NAME), }; -static const struct ata_port_operations scc_pata_ops = { +static struct ata_port_operations scc_pata_ops = { .inherits = &ata_bmdma_port_ops, .set_piomode = scc_set_piomode, ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream] pata_scc: fix compile warning 2008-03-27 10:44 ` [PATCH #upstream] pata_scc: fix compile warning Tejun Heo @ 2008-04-04 7:40 ` Jeff Garzik 0 siblings, 0 replies; 2+ messages in thread From: Jeff Garzik @ 2008-04-04 7:40 UTC (permalink / raw) To: Tejun Heo; +Cc: Stephen Rothwell, linux-next, IDE/ATA development list Tejun Heo wrote: > Missed one during mass conversion (dc14c0c5). Fix it. Spotted by > Stephen Rothwell. > > Signed-off-by: Tejun Heo <htejun@gmail.com> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > --- > Stephen Rothwell wrote: >> Hi Jeff, Tejun (Heo? I am sorry if I chose the wrong name), > > Yeap, Tejun is fine. > >> Today's build of linux-next produces this warning: >> >> drivers/ata/pata_scc.c:1002: warning: initialization discards >> qualifiers from pointer target type >> >> Presumably caused by commit dc14c0c5012855bfc9a5f76056b92f198d52834c >> ("libata: implement and use ops inheritance"). > > Thanks for spotting this. I couldn't compile test platform specific > ones. Hmm... pata_scc doesn't seem to have platform dependencies, > maybe we can drop PPC_CELLEB dependency. > > drivers/ata/pata_scc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c > index 07f2d7a..f6a6ce1 100644 > --- a/drivers/ata/pata_scc.c > +++ b/drivers/ata/pata_scc.c > @@ -960,7 +960,7 @@ static struct scsi_host_template scc_sht = { > ATA_BMDMA_SHT(DRV_NAME), > }; > > -static const struct ata_port_operations scc_pata_ops = { > +static struct ata_port_operations scc_pata_ops = { > .inherits = &ata_bmdma_port_ops, > applied ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-04 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080327151331.e11d3665.sfr@canb.auug.org.au>
2008-03-27 10:44 ` [PATCH #upstream] pata_scc: fix compile warning Tejun Heo
2008-04-04 7:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).