From: Tejun Heo <htejun@gmail.com>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Zoltan Boszormenyi <zboszor@dunaweb.hu>,
akpm@linux-foundation.org, jeff@garzik.org,
linux-ide@vger.kernel.org, Kuan Luo <kluo@nvidia.com>,
Peer Chen <pchen@nvidia.com>
Subject: Re: [patch 3/3] ata: SWNCQ should be enabled by default
Date: Sun, 30 Mar 2008 10:17:31 +0900 [thread overview]
Message-ID: <47EEEA2B.8010204@gmail.com> (raw)
In-Reply-To: <47EEE784.8090909@shaw.ca>
Robert Hancock wrote:
> Tejun Heo wrote:
>> Zoltan Boszormenyi wrote:
>>> Tejun Heo írta:
>>>> akpm@linux-foundation.org wrote:
>>>>> From: Zoltan Boszormenyi <zboszor@dunaweb.hu>
>>>>>
>>>>> unchangelogged patch.
>>>>>
>>>>> Signed-off-by: Zoltan Boszormenyi <zboszor@dunaweb.hu>
>>>>> Cc: Robert Hancock <hancockr@shaw.ca>
>>>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>>>
>>>> Nacked-by: Tejun Heo <htejun@gmail.com>
>>>>
>>>> Sorry, there are remaining issues to resolve before enabling ADMA by
>>>> default.
>>>
>>> Sorry, this is NOT ADMA. SWNCQ is completely independent from ADMA.
>>
>> Heh, right. Sorry about that. I disabled ADMA on the distro I work
>> for and somehow ADMA was disabled on mainline too. :-)
>>
>> Robert, is SWNCQ safe to turn on by default? I personally think it's
>> better to prefer safety over performance or optional features and
>> given the history of NCQ support on nv satas, I feel a bit more cautious.
>>
>> Maybe we can enable SWNCQ on -mm and devel branches and disable it
>> late in release cycle for 2.6.26 for a trial?
>
> I haven't seen any problem reports, but with it disabled by default most
> people haven't tried it. The only way to really know is to try turning
> it on by default and see what shakes out.
>
> I'd vote to enable it by default in -mm and 2.6.26-rc and see what happens.
Alright, Zoltan can you please repost w/ commit message fixed and
comment stating /* FIXME: for testing during blah blah */ added?
--
tejun
next prev parent reply other threads:[~2008-03-30 1:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:33 [patch 3/3] ata: SWNCQ should be enabled by default akpm
2008-03-29 13:38 ` Tejun Heo
2008-03-29 18:22 ` Zoltan Boszormenyi
2008-03-30 0:11 ` Tejun Heo
2008-03-30 1:06 ` Robert Hancock
2008-03-30 1:17 ` Tejun Heo [this message]
2008-03-30 7:03 ` Zoltan Boszormenyi
2008-03-30 10:59 ` Tejun Heo
2008-03-31 2:58 ` Kuan Luo
2008-03-31 4:34 ` Tejun Heo
2008-04-01 3:14 ` Robert Hancock
2008-04-01 3:24 ` Robert Hancock
2008-04-01 5:24 ` Kuan Luo
2008-04-04 7:38 ` Jeff Garzik
2008-04-04 8:10 ` Jeff Garzik
2008-04-04 14:34 ` Robert Hancock
2008-04-05 0:00 ` Tejun Heo
2008-04-04 7:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EEEA2B.8010204@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=zboszor@dunaweb.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).