linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Tomas Lund <tlund@nxs.se>,
	linux-ide@vger.kernel.org, Robert Hancock <hancockr@shaw.ca>
Subject: Re: Need help understanding SATA error message.
Date: Tue, 01 Apr 2008 09:26:15 +0900	[thread overview]
Message-ID: <47F18127.8070509@gmail.com> (raw)
In-Reply-To: <47F0FAD3.9060001@rtr.ca>

Mark Lord wrote:
>> The response to an unrecoverable sector shouldn't be 51/04 if the
>> flush fails, it should be 51/10 or 51/40.
>>
>> 51/04 would be the response if the FLUSH CACHE command was issued when
>> there were still outstanding NCQ commands active.
> ..
> 
> Tejun:  I see we have another thread as well with FLUSH errors.
> I really doubt that these are bad drives.
> There's very likely a bug in libata / LLD there someplace.

Possibly.  The only thing I can think of which can screw FLUSH is 
issuing it when NCQ phase is still in progress as was in the case for 
ADMA.  FLUSH being a non-data command, it's pretty difficult to get it 
wrong otherwise.  The thing is that sata_sil24 does its own command 
sequencing and even if libata slips there a bit, the silicon won't issue 
FLUSH if NCQ is in progress, so I'm a bit skeptical.  Any other ideas?

-- 
tejun

  reply	other threads:[~2008-04-01  0:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  7:04 Need help understanding SATA error message Tomas Lund
2008-03-28 13:40 ` Jeff Garzik
2008-03-28 14:28   ` Tomas Lund
2008-03-28 15:49 ` Mark Lord
2008-03-28 15:59   ` Mark Lord
2008-03-28 22:21     ` Tomas Lund
2008-03-29  3:50       ` Mark Lord
2008-03-30 15:01         ` Tomas Lund
2008-03-31  0:59           ` Tejun Heo
2008-03-31 14:53             ` Mark Lord
2008-04-01  0:26               ` Tejun Heo [this message]
2008-04-01  2:01                 ` Mark Lord
2008-04-01  7:11                   ` Tomas Lund
2008-04-01 12:05                     ` Mark Lord
2008-04-01 16:15                       ` Tejun Heo
2008-04-02  5:17                         ` Tomas Lund
2008-04-03 10:39                           ` Tomas Lund
2008-04-11  6:16                             ` Tejun Heo
2008-03-29  3:54       ` Mark Lord
2008-03-29 10:39         ` Tomas Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F18127.8070509@gmail.com \
    --to=htejun@gmail.com \
    --cc=hancockr@shaw.ca \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=tlund@nxs.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).