* [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe()
@ 2008-04-02 1:35 Tejun Heo
2008-04-04 6:46 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-04-02 1:35 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list, Bartlomiej Zolnierkiewicz
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Commit f58229f8060055b08b34008ea08f31de1e2f003c accidentally made
ata_bus_probe() not use reverse order probing. Fix it.
There currently isn't any PATA driver which uses obsolete
ata_bus_probe() path, so this patch is mainly for correctness.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4851988..2db5c9c 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2660,7 +2660,7 @@ int ata_bus_probe(struct ata_port *ap)
specific sequence bass-ackwards so that PDIAG- is released by
the slave device */
- ata_link_for_each_dev(dev, &ap->link) {
+ ata_link_for_each_dev_reverse(dev, &ap->link) {
if (tries[dev->devno])
dev->class = classes[dev->devno];
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe()
2008-04-02 1:35 [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe() Tejun Heo
@ 2008-04-04 6:46 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-04 6:46 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, Bartlomiej Zolnierkiewicz
Tejun Heo wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Commit f58229f8060055b08b34008ea08f31de1e2f003c accidentally made
> ata_bus_probe() not use reverse order probing. Fix it.
>
> There currently isn't any PATA driver which uses obsolete
> ata_bus_probe() path, so this patch is mainly for correctness.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4851988..2db5c9c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2660,7 +2660,7 @@ int ata_bus_probe(struct ata_port *ap)
> specific sequence bass-ackwards so that PDIAG- is released by
> the slave device */
>
> - ata_link_for_each_dev(dev, &ap->link) {
> + ata_link_for_each_dev_reverse(dev, &ap->link) {
> if (tries[dev->devno])
> dev->class = classes[dev->devno];
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-04 6:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-02 1:35 [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe() Tejun Heo
2008-04-04 6:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).