* [PATCH] sata_svw: 0x0241 has 8 ports not 4
@ 2008-04-10 0:55 Tejun Heo
2008-04-10 1:21 ` Benjamin Herrenschmidt
2008-04-11 22:24 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Tejun Heo @ 2008-04-10 0:55 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list, y_honda_,
Benjamin Herrenschmidt
From: Yohei Honda <y_honda_@d1.dion.ne.jp>
0x0241 has 8 ports not 4.
Reported by Yohei Honda on kernel bz 10424.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Benjamin, can you please verify this is correct?
drivers/ata/sata_svw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
index 840d1c4..75c6853 100644
--- a/drivers/ata/sata_svw.c
+++ b/drivers/ata/sata_svw.c
@@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, const struct pci_device_id *en
* */
static const struct pci_device_id k2_sata_pci_tbl[] = {
{ PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
- { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
+ { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
{ PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
{ PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
{ PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
2008-04-10 0:55 [PATCH] sata_svw: 0x0241 has 8 ports not 4 Tejun Heo
@ 2008-04-10 1:21 ` Benjamin Herrenschmidt
2008-04-10 1:46 ` Tejun Heo
2008-04-11 22:24 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2008-04-10 1:21 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, IDE/ATA development list, y_honda_
On Thu, 2008-04-10 at 09:55 +0900, Tejun Heo wrote:
> From: Yohei Honda <y_honda_@d1.dion.ne.jp>
>
> 0x0241 has 8 ports not 4.
>
> Reported by Yohei Honda on kernel bz 10424.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Benjamin, can you please verify this is correct?
I can't as I don't have any spec for these... All I can say is that the
Apple one has 4 ports and is is 0x0240.
So If you are reasonably confident the 0x0241 has 8, then feel free to
apply the patch.
Cheers,
Ben.
> drivers/ata/sata_svw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
> index 840d1c4..75c6853 100644
> --- a/drivers/ata/sata_svw.c
> +++ b/drivers/ata/sata_svw.c
> @@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev, const struct pci_device_id *en
> * */
> static const struct pci_device_id k2_sata_pci_tbl[] = {
> { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
> - { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
> + { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
> { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
2008-04-10 1:21 ` Benjamin Herrenschmidt
@ 2008-04-10 1:46 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2008-04-10 1:46 UTC (permalink / raw)
To: benh; +Cc: Jeff Garzik, IDE/ATA development list, y_honda_
Benjamin Herrenschmidt wrote:
> On Thu, 2008-04-10 at 09:55 +0900, Tejun Heo wrote:
>> From: Yohei Honda <y_honda_@d1.dion.ne.jp>
>>
>> 0x0241 has 8 ports not 4.
>>
>> Reported by Yohei Honda on kernel bz 10424.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>> Benjamin, can you please verify this is correct?
>
> I can't as I don't have any spec for these... All I can say is that the
> Apple one has 4 ports and is is 0x0240.
>
> So If you are reasonably confident the 0x0241 has 8, then feel free to
> apply the patch.
Hmmm.. Honda apparently has the hardware and this change works for him.
I think that should be good enough. Jeff, can you please merge this?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
2008-04-10 0:55 [PATCH] sata_svw: 0x0241 has 8 ports not 4 Tejun Heo
2008-04-10 1:21 ` Benjamin Herrenschmidt
@ 2008-04-11 22:24 ` Jeff Garzik
2008-04-12 1:11 ` Anantha Subramanyam
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2008-04-11 22:24 UTC (permalink / raw)
To: Tejun Heo
Cc: IDE/ATA development list, y_honda_, Benjamin Herrenschmidt,
Anantha Subramanyam
Tejun Heo wrote:
> From: Yohei Honda <y_honda_@d1.dion.ne.jp>
>
> 0x0241 has 8 ports not 4.
>
> Reported by Yohei Honda on kernel bz 10424.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Benjamin, can you please verify this is correct?
>
> drivers/ata/sata_svw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
> index 840d1c4..75c6853 100644
> --- a/drivers/ata/sata_svw.c
> +++ b/drivers/ata/sata_svw.c
> @@ -531,7 +531,7 @@ static int k2_sata_init_one(struct pci_dev *pdev,
> const struct pci_device_id *en
> * */
> static const struct pci_device_id k2_sata_pci_tbl[] = {
> { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
> - { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
> + { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
> { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
> { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
This is wrong according to my docs.
Anantha, can you provide a definitive answer?
Does PCI ID 0x241 support 4 ports or 8 ports?
Thanks,
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] sata_svw: 0x0241 has 8 ports not 4
2008-04-11 22:24 ` Jeff Garzik
@ 2008-04-12 1:11 ` Anantha Subramanyam
2008-04-12 1:39 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Anantha Subramanyam @ 2008-04-12 1:11 UTC (permalink / raw)
To: Tejun Heo, Jeff Garzik
Cc: Benjamin Herrenschmidt, IDE/ATA development list, y_honda_
> -----Original Message-----
> From: Jeff Garzik [mailto:jeff@garzik.org]
> Sent: Friday, April 11, 2008 3:25 PM
> To: Tejun Heo
> Cc: IDE/ATA development list; y_honda_@d1.dion.ne.jp;
> Benjamin Herrenschmidt; Anantha Subramanyam
> Subject: Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
>
> Tejun Heo wrote:
> > From: Yohei Honda <y_honda_@d1.dion.ne.jp>
> >
> > 0x0241 has 8 ports not 4.
> >
> > Reported by Yohei Honda on kernel bz 10424.
> >
> > Signed-off-by: Tejun Heo <htejun@gmail.com>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > Benjamin, can you please verify this is correct?
> >
> > drivers/ata/sata_svw.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
> > index 840d1c4..75c6853 100644
> > --- a/drivers/ata/sata_svw.c
> > +++ b/drivers/ata/sata_svw.c
> > @@ -531,7 +531,7 @@ static int k2_sata_init_one(struct
> pci_dev *pdev,
> > const struct pci_device_id *en
> > * */
> > static const struct pci_device_id k2_sata_pci_tbl[] = {
> > { PCI_VDEVICE(SERVERWORKS, 0x0240), chip_svw4 },
> > - { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw4 },
> > + { PCI_VDEVICE(SERVERWORKS, 0x0241), chip_svw8 },
> > { PCI_VDEVICE(SERVERWORKS, 0x0242), chip_svw8 },
> > { PCI_VDEVICE(SERVERWORKS, 0x024a), chip_svw4 },
> > { PCI_VDEVICE(SERVERWORKS, 0x024b), chip_svw4 },
>
> This is wrong according to my docs.
>
> Anantha, can you provide a definitive answer?
>
> Does PCI ID 0x241 support 4 ports or 8 ports?
>
> Thanks,
>
> Jeff
>
>
0x241 is 8 ports
0x242 is 4 ports
Thanks,
Ananth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sata_svw: 0x0241 has 8 ports not 4
2008-04-12 1:11 ` Anantha Subramanyam
@ 2008-04-12 1:39 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2008-04-12 1:39 UTC (permalink / raw)
To: Anantha Subramanyam
Cc: Tejun Heo, Benjamin Herrenschmidt, IDE/ATA development list,
y_honda_
Anantha Subramanyam wrote:
> 0x241 is 8 ports
> 0x242 is 4 ports
Thanks!
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-04-12 1:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 0:55 [PATCH] sata_svw: 0x0241 has 8 ports not 4 Tejun Heo
2008-04-10 1:21 ` Benjamin Herrenschmidt
2008-04-10 1:46 ` Tejun Heo
2008-04-11 22:24 ` Jeff Garzik
2008-04-12 1:11 ` Anantha Subramanyam
2008-04-12 1:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).