* [2.6 patch] make ali_atapi_dma static
@ 2008-04-11 17:28 Adrian Bunk
2008-04-11 18:36 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-04-11 17:28 UTC (permalink / raw)
To: Tejun Heo, Jeff Garzik; +Cc: linux-ide, linux-kernel
This patch makes the needlessly global ali_atapi_dma static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
de012fdf57e025cf243181cb3fce87f890ccc955 diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index ce830fe..511a830 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -36,7 +36,7 @@
#define DRV_NAME "pata_ali"
#define DRV_VERSION "0.7.5"
-int ali_atapi_dma = 0;
+static int ali_atapi_dma = 0;
module_param_named(atapi_dma, ali_atapi_dma, int, 0644);
MODULE_PARM_DESC(atapi_dma, "Enable ATAPI DMA (0=disable, 1=enable)");
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] make ali_atapi_dma static
2008-04-11 17:28 [2.6 patch] make ali_atapi_dma static Adrian Bunk
@ 2008-04-11 18:36 ` Alan Cox
2008-04-12 1:07 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2008-04-11 18:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Tejun Heo, Jeff Garzik, linux-ide, linux-kernel
On Fri, 11 Apr 2008 20:28:27 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> This patch makes the needlessly global ali_atapi_dma static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] make ali_atapi_dma static
2008-04-11 18:36 ` Alan Cox
@ 2008-04-12 1:07 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2008-04-12 1:07 UTC (permalink / raw)
To: Alan Cox; +Cc: Adrian Bunk, Jeff Garzik, linux-ide, linux-kernel
Alan Cox wrote:
> On Fri, 11 Apr 2008 20:28:27 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
>> This patch makes the needlessly global ali_atapi_dma static.
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Acked-by: Alan Cox <alan@redhat.com>
Acked-by: Tejun Heo <htejun@gmail.com>
What was I thinking?
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-12 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 17:28 [2.6 patch] make ali_atapi_dma static Adrian Bunk
2008-04-11 18:36 ` Alan Cox
2008-04-12 1:07 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).