From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>, Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream 1/2] libata: kill dead code paths in reset path
Date: Sat, 12 Apr 2008 00:35:16 -0400 [thread overview]
Message-ID: <48003C04.4040508@garzik.org> (raw)
In-Reply-To: <47FA4AFF.2010209@gmail.com>
Tejun Heo wrote:
> Some code paths which had been made obsolete by recent reset
> simplification were still around. Kill them.
>
> * ata_eh_reset() checked for ATA_DEV_UNKNOWN to determine
> classification failure. This is no longer applicable.
>
> * ata_do_reset() should convert ATA_DEV_UNKNOWN to ATA_DEV_NONE
> regardless of reset result (e.g. -EAGAIN).
>
> * LLDs don't need to convert ATA_DEV_UNKNOWN to ATA_DEV_NONE.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 19 +------------------
> drivers/ata/sata_inic162x.c | 2 --
> drivers/ata/sata_sil24.c | 3 ---
> 3 files changed, 1 insertion(+), 23 deletions(-)
applied 1-2
Mark, let us know how we stand WRT sata_mv PMP needs, this should help.
next prev parent reply other threads:[~2008-04-12 4:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 16:25 [PATCH #upstream 1/2] libata: kill dead code paths in reset path Tejun Heo
2008-04-07 16:46 ` [PATCH #upstream 2/2] libata: move link onlineness check out of softreset methods Tejun Heo
2008-04-12 4:35 ` Jeff Garzik [this message]
2008-04-13 16:27 ` [PATCH #upstream 1/2] libata: kill dead code paths in reset path Mark Lord
2008-04-14 20:52 ` sata_mv & pmp support Mark Lord
2008-04-15 2:01 ` Tejun Heo
2008-04-15 14:03 ` Mark Lord
2008-04-15 14:04 ` Mark Lord
[not found] ` <4803C850.9010901@rtr.ca>
2008-04-15 2:07 ` Tejun Heo
2008-04-15 19:59 ` Mark Lord
2008-04-15 20:14 ` Mark Lord
2008-04-15 22:36 ` Tejun Heo
2008-04-15 22:53 ` Mark Lord
2008-04-16 2:03 ` Mark Lord
2008-04-16 2:10 ` Tejun Heo
2008-04-16 7:05 ` Gwendal Grignou
2008-04-16 12:43 ` Mark Lord
2008-04-16 12:37 ` Mark Lord
2008-04-16 12:45 ` Mark Lord
2008-04-16 15:41 ` Mark Lord
2008-04-16 22:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48003C04.4040508@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).