From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] libata: Be a bit more slack about early devices
Date: Sat, 12 Apr 2008 00:35:30 -0400 [thread overview]
Message-ID: <48003C12.40509@garzik.org> (raw)
In-Reply-To: <20080408163644.322f5a6d@core>
Alan Cox wrote:
> We have a certain number of 'ATA' emulations often on CF or other flash
> devices that are at best "loosely based" on the CF 1.1 standard. These
> devices report themselves as disk but don't support the ATA minimal
> command set only the CF 1.1 set.
>
> Relax the PIO checking for devices reporting ATA rev 0, or no iordy
> support, or CFA. Rework the code a bit as it was already messy and this
> made it quite ugly.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 11:34:51.000000000 +0100
> +++ linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 12:01:30.000000000 +0100
> @@ -3342,16 +3342,21 @@
> if (rc)
> return rc;
>
> - /* Old CFA may refuse this command, which is just fine */
> - if (dev->xfer_shift == ATA_SHIFT_PIO && ata_id_is_cfa(dev->id))
> - ign_dev_err = 1;
> -
> - /* Some very old devices and some bad newer ones fail any kind of
> - SET_XFERMODE request but support PIO0-2 timings and no IORDY */
> - if (dev->xfer_shift == ATA_SHIFT_PIO && !ata_id_has_iordy(dev->id) &&
> - dev->pio_mode <= XFER_PIO_2)
> - ign_dev_err = 1;
> -
> + if (dev->xfer_shift == ATA_SHIFT_PIO) {
> + /* Old CFA may refuse this command, which is just fine */
> + if (ata_id_is_cfa(dev->id))
> + ign_dev_err = 1;
> + /* Catch several broken garbage emulations plus some pre
> + ATA devices */
> + if (ata_id_major_version(dev->id) == 0 &&
> + dev->pio_mode <= XFER_PIO_2)
> + ign_dev_err = 1;
> + /* Some very old devices and some bad newer ones fail
> + any kind of SET_XFERMODE request but support PIO0-2
> + timings and no IORDY */
> + if (!ata_id_has_iordy(dev->id) && dev->pio_mode <= XFER_PIO_2)
> + ign_dev_err = 1;
> + }
applied
prev parent reply other threads:[~2008-04-12 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 15:36 [PATCH] libata: Be a bit more slack about early devices Alan Cox
2008-04-12 4:35 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48003C12.40509@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).