From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ide: add struct ide_dma_ops
Date: Sat, 12 Apr 2008 21:54:06 +0400 [thread overview]
Message-ID: <4800F73E.3000802@ru.mvista.com> (raw)
In-Reply-To: <200804121432.03366.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
>>>> Now where is the code which selects the correct dma_ops for the
>>>>>HPT36x/370/372/372N chip with device ID 4 I'm asking you? :-)
>>>fixed
>> Not actually... :-/
> Arghhh. I see now that the HPT370/370A needs a special handling...
Yes, and a lot of. :-)
> (HPT372/372N has already been handled by 'idx++')
Didn't grasp this at first - the init. code grew somewhat convoluted...
> [...]
>>>@@ -1483,6 +1489,7 @@ static const struct ide_port_info hpt366
>>> .enablebits = {{0x50,0x04,0x04}, {0x54,0x04,0x04}},
>>> .udma_mask = ATA_UDMA5,
>>> .port_ops = &hpt3xx_port_ops,
>>>+ .dma_ops = &hpt370_dma_ops,
>> Wrong -- HPT374 should have hpt37x_dma_ops...
> Yep, thanks for catching it.
> interdiff between v2->v3:
> [...]
> v3:
> * Two bugs slipped in v2 (noticed by Sergei):
> - use correct DMA ops for HPT374 (for real this time)
> - handle HPT370/HPT370A properly
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2008-04-12 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 16:00 [PATCH 3/4] ide: add struct ide_dma_ops Bartlomiej Zolnierkiewicz
2008-03-12 19:27 ` Sergei Shtylyov
2008-03-18 14:12 ` Bartlomiej Zolnierkiewicz
2008-04-11 13:11 ` Sergei Shtylyov
2008-04-12 12:32 ` Bartlomiej Zolnierkiewicz
2008-04-12 17:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4800F73E.3000802@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).