* [2.6 patch] libata-acpi.c: remove unneeded #if's
@ 2008-04-14 18:40 Adrian Bunk
2008-04-15 2:07 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:40 UTC (permalink / raw)
To: Tejun Heo, Jeff Garzik; +Cc: linux-ide, linux-kernel
These #if's are unneeded since they:
- did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
- this is already handled in include/acpi/acpi_drivers.h and
- it's now correctly handled in kconfig.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 31 Mar 2008
drivers/ata/libata-acpi.c | 4 ----
1 file changed, 4 deletions(-)
2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index bf98a56..1db912e 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(ap->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_ap_notify, ap);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(ap->acpi_handle,
ata_acpi_ap_notify, ap);
-#endif
}
for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
@@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(dev->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_dev_notify, dev);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(dev->acpi_handle,
ata_acpi_dev_notify, dev);
-#endif
}
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* [2.6 patch] libata-acpi.c: remove unneeded #if's
@ 2008-04-21 22:50 Adrian Bunk
2008-04-25 4:48 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-04-21 22:50 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Tejun Heo, linux-ide, linux-kernel
These #if's are unneeded since they:
- did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
- this is already handled in include/acpi/acpi_drivers.h and
- it's now correctly handled in kconfig.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Tejun Heo <htejun@gmail.com>
---
This patch has been sent on:
- 14 Apr 2008
- 31 Mar 2008
drivers/ata/libata-acpi.c | 4 ----
1 file changed, 4 deletions(-)
2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index bf98a56..1db912e 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(ap->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_ap_notify, ap);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(ap->acpi_handle,
ata_acpi_ap_notify, ap);
-#endif
}
for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
@@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(dev->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_dev_notify, dev);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(dev->acpi_handle,
ata_acpi_dev_notify, dev);
-#endif
}
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [2.6 patch] libata-acpi.c: remove unneeded #if's
2008-04-21 22:50 Adrian Bunk
@ 2008-04-25 4:48 ` Jeff Garzik
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2008-04-25 4:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Tejun Heo, linux-ide, linux-kernel
Adrian Bunk wrote:
> These #if's are unneeded since they:
> - did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
> - this is already handled in include/acpi/acpi_drivers.h and
> - it's now correctly handled in kconfig.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Acked-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> This patch has been sent on:
> - 14 Apr 2008
> - 31 Mar 2008
>
> drivers/ata/libata-acpi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> 2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index bf98a56..1db912e 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
> acpi_install_notify_handler(ap->acpi_handle,
> ACPI_SYSTEM_NOTIFY,
> ata_acpi_ap_notify, ap);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
> /* we might be on a docking station */
> register_hotplug_dock_device(ap->acpi_handle,
> ata_acpi_ap_notify, ap);
> -#endif
> }
>
> for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
> @@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
> acpi_install_notify_handler(dev->acpi_handle,
> ACPI_SYSTEM_NOTIFY,
> ata_acpi_dev_notify, dev);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
> /* we might be on a docking station */
> register_hotplug_dock_device(dev->acpi_handle,
> ata_acpi_dev_notify, dev);
> -#endif
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] libata-acpi.c: remove unneeded #if's
@ 2008-03-30 23:05 Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2008-03-30 23:05 UTC (permalink / raw)
To: Tejun Heo, Jeff Garzik; +Cc: linux-ide, linux-kernel
These #if's are unneeded since they:
- did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
- this is already handled in include/acpi/acpi_drivers.h and
- it's now correctly handled in kconfig.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/ata/libata-acpi.c | 4 ----
1 file changed, 4 deletions(-)
2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index bf98a56..1db912e 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(ap->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_ap_notify, ap);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(ap->acpi_handle,
ata_acpi_ap_notify, ap);
-#endif
}
for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
@@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
acpi_install_notify_handler(dev->acpi_handle,
ACPI_SYSTEM_NOTIFY,
ata_acpi_dev_notify, dev);
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
/* we might be on a docking station */
register_hotplug_dock_device(dev->acpi_handle,
ata_acpi_dev_notify, dev);
-#endif
}
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-25 4:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 18:40 [2.6 patch] libata-acpi.c: remove unneeded #if's Adrian Bunk
2008-04-15 2:07 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2008-04-21 22:50 Adrian Bunk
2008-04-25 4:48 ` Jeff Garzik
2008-03-30 23:05 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).