Re: sata_mv & pmp support

[Mark Lord <liml@rtr.ca>]

Tejun Heo wrote:
> Hello, Mark.
> 
> Mark Lord wrote:
>> Well, I've spent much of the day porting to the new interfaces,
>> and then trying to get things working again.
..
>>
>> Do you have any recommendations on exactly what should be in
>> mv_pmp_softreset() and mv_softreset() and mv_hardreset() under this 
>> scheme?
>>
>> My basic attempt was to try this:
>>
>> No prereset or postreset handlers of any kind.
> 
> Yes.
> 
>> mv_hardreset():  as in the hardreset rework patch (yet to be picked up
>> by Jeff), plus a call to mv_select_pmp(link->ap, SATA_PMP_CTRL_PORT)
>> before the sata_link_hardreset() wrapper loop.
> 
> Yes.
> 
>> mv_softreset():
>> First do mv_select_pmp(link->ap, SATA_PMP_CTRL_PORT),
>> and then call ata_sff_softreset().
>>
>> mv_pmp_softreset():
>> First do mv_select_pmp(link->ap, link->pmp),
>> and then call ata_sff_softreset().
> 
> You can just use mv_select_pmp(link->ap, sata_srst_pmp(link)) in 
> mv_softreset() and use it for both mv_softreset() and mv_pmp_softreset().
..

?? But the ports are different, aren't they?
Or is link->


> 
>> Resets of the pmp ports always fail with SRST failed (errno=-16).
> 
> Hmm... That's -EBUSY.  I'll continue on the reply of the other mail.
>