From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: sata_mv & pmp support Date: Wed, 16 Apr 2008 07:36:56 +0900 Message-ID: <48052E08.5040306@gmail.com> References: <47FA4AFF.2010209@gmail.com> <48003C04.4040508@garzik.org> <48023462.1050305@rtr.ca> <4803C429.6070201@rtr.ca> <4803C850.9010901@rtr.ca> <48040DC8.1050907@gmail.com> <48050904.1040808@rtr.ca> <48050CA1.5010800@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rv-out-0708.google.com ([209.85.198.241]:3674 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751434AbYDOWhD (ORCPT ); Tue, 15 Apr 2008 18:37:03 -0400 Received: by rv-out-0506.google.com with SMTP id k29so983578rvb.1 for ; Tue, 15 Apr 2008 15:37:02 -0700 (PDT) In-Reply-To: <48050CA1.5010800@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Jeff Garzik , IDE/ATA development list Mark Lord wrote: > Heh. Okay, apparently it now needs a .pmp_hardreset function, > which was never there before. So I've now added one that does this: Ah... right. That's something changed while changing libata EH to favor hardreset over softreset. With the change, resuming link on PMP fan out ports became hardreset's responsibility, which BTW is necessary anyway for certain PMPs (marvell ones). So, one way or another, you need pmp_hardreset. > mv_pmp_select(link->ap, sata_srst_pmp(link)); > return sata_std_hardreset(link, class, deadline); > > And it seems to be working now with that function supplied, at least for > port-0. > Anything else new that it should have? I'll scan through libata-pmp.c > and see. The hardreset thing was the only behavior change if I didn't screw up. It wasn't supposed to cause any actual behavior change tho as all PMP supporting PMPs are supposed to have SCR access on fan-out ports and thus the capability to hardreset them. > Time to clean out the debug cruft and test a few things a bit more. Great. :-) -- tejun