From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: sata_mv & pmp support Date: Wed, 16 Apr 2008 11:41:04 -0400 Message-ID: <48061E10.4000604@rtr.ca> References: <47FA4AFF.2010209@gmail.com> <48003C04.4040508@garzik.org> <48023462.1050305@rtr.ca> <4803C429.6070201@rtr.ca> <4803C850.9010901@rtr.ca> <48040DC8.1050907@gmail.com> <48050904.1040808@rtr.ca> <48050CA1.5010800@rtr.ca> <48052E08.5040306@gmail.com> <480531DB.3020602@rtr.ca> <48055E7C.1060004@rtr.ca> <48056016.6020900@gmail.com> <4805F4E6.7020903@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:1658 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933115AbYDPPlG (ORCPT ); Wed, 16 Apr 2008 11:41:06 -0400 In-Reply-To: <4805F4E6.7020903@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , IDE/ATA development list Mark Lord wrote: > Tejun Heo wrote: >> Mark Lord wrote: > .. >>> I've just noticed that, if I unplug/replug the host-side SATA cable >>> on the Sil3726 PM, and *then* "insmod sata_mv", the PM is not found. >>> >>> If I then simply do "rmmod sata_mv ; insmod sata_mv", then the PM is >>> found. >>> >>> This happens with the original hardreset code from Jeff, >>> as well as the updated sata_mv code that I've posted earlier. >>> So it is not anything I've broken (recently :) ). >>> >>> Very strange.. I wonder if it also happens with the Marvell PM, >>> except I don't have one here to test with at the moment. >>> >>> Ever heard of anything strange like that? >> >> IIRC, ICH8 ahci + 4726 fails the initial reset sequence because the >> PMP comes up after the hardreset code times out, which triggers >> another EH iteration which works out fine. If the problem is caused >> by the PMP not responding fast enough, it should cause a hotplug event >> afterwards. > .. > > So I ought to be able to insert (for debug purposes only) a msleep(3000) > at an appropriate location in the code, and suddenly see this problem go > away? > > Not for upstream -- the eventual hotplug support in sata_mv is the real solution. > But just to confirm that this is indeed the issue. .. Heh.. darned near exactly 3 seconds does it, alright. Okay, I won't fuss over this for now -- it works if the PM is plugged in at boot (because the BIOS fiddles it first), and it works when warmplugged so long as sata_mv is unloaded and reloaded. This will get fixed completely with the hotplug support fixes coming later this week. Cheers